os: skip TestExecutableDeleted earlier when 'go build' is not supported

Bryan C. Mills · gopherbot · commit 53c91f9205e2 · 2023-03-10T21:27:06.000Z
The test unconditionally calls testenv.GoToolPath, which will skip the test anyway. Moving the skip earlier gets this test out of goroutine dumps if the test process fails or times out, making it easier to diagnose failures in the remaining tests. Change-Id: Ibd39546708a83b6f15616b2c4ae7af420e2401f0 Reviewed-on: https://go-review.googlesource.com/c/go/+/475455 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
diff --git a/src/os/executable_test.go b/src/os/executable_test.go
@@ -89,7 +89,7 @@ func init() {
 }
 
 func TestExecutableDeleted(t *testing.T) {
-	testenv.MustHaveExec(t)
+	testenv.MustHaveGoBuild(t)
 	switch runtime.GOOS {
 	case "windows", "plan9":
 		t.Skipf("%v does not support deleting running binary", runtime.GOOS)

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ func init() {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`func TestExecutableDeleted(t *testing.T) {`
`92`		`- testenv.MustHaveExec(t)`
	`92`	`+ testenv.MustHaveGoBuild(t)`
`93`	`93`	`switch runtime.GOOS {`
`94`	`94`	`case "windows", "plan9":`
`95`	`95`	`t.Skipf("%v does not support deleting running binary", runtime.GOOS)`