Skip to content

Commit 4dce6db

Browse files
committed
math/big: temporarily disable buggy shlVU assembly for arm64
This addresses the failures we have seen in #31084. The correct fix is to find the actual bug in the assembly code. Updates #31084. Change-Id: I437780c53d0c4423d742e2e3b650b899ce845372 Reviewed-on: https://go-review.googlesource.com/c/go/+/169721 Run-TryBot: Robert Griesemer <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 591193b commit 4dce6db

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/math/big/arith_arm64.s

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,10 @@ len0:
197197

198198
// func shlVU(z, x []Word, s uint) (c Word)
199199
TEXT ·shlVU(SB),NOSPLIT,$0
200+
// Disable assembly for now - it is subtly incorrect.
201+
// See #31084 for a test that fails using this code.
202+
B ·shlVU_g(SB)
203+
200204
MOVD z+0(FP), R0
201205
MOVD z_len+8(FP), R1
202206
MOVD x+24(FP), R2

0 commit comments

Comments
 (0)