cmd/compile: do not set type for OTYPE

cuonglm · cuonglm · commit 4b8b2c58647a · 2021-03-04T06:36:17.000Z
That's an invalid operation and depend on gc.hidePanic to report error. Updates #43311 Change-Id: Ib0761dcf4d9d2a23c41de7eff0376677a90b942e Reviewed-on: https://go-review.googlesource.com/c/go/+/294033 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
diff --git a/src/cmd/compile/internal/typecheck/typecheck.go b/src/cmd/compile/internal/typecheck/typecheck.go
@@ -433,8 +433,8 @@ func typecheck(n ir.Node, top int) (res ir.Node) {
 	case top&ctxType == 0 && n.Op() == ir.OTYPE && t != nil:
 		if !n.Type().Broke() {
 			base.Errorf("type %v is not an expression", n.Type())
+			n.SetDiag(true)
 		}
-		n.SetType(nil)
 
 	case top&(ctxStmt|ctxExpr) == ctxStmt && !isStmt && t != nil:
 		if !n.Diag() {

Original file line number	Diff line number	Diff line change
`@@ -433,8 +433,8 @@ func typecheck(n ir.Node, top int) (res ir.Node) {`
`433`	`433`	`case top&ctxType == 0 && n.Op() == ir.OTYPE && t != nil:`
`434`	`434`	`if !n.Type().Broke() {`
`435`	`435`	`base.Errorf("type %v is not an expression", n.Type())`
	`436`	`+ n.SetDiag(true)`
`436`	`437`	`}`
`437`		`- n.SetType(nil)`
`438`	`438`
`439`	`439`	`case top&(ctxStmt\|ctxExpr) == ctxStmt && !isStmt && t != nil:`
`440`	`440`	`if !n.Diag() {`