Skip to content

Commit 49073c5

Browse files
minuxtoothrot
authored andcommitted
[release-branch.go1.13] os: re-enable TestPipeThreads on darwin
CL 197938 actually fixes those regression on Darwin as syscalls are no longer labeled as always blocking and consume a thread. Fixes #34712 Change-Id: I82c98516c23cd36f762bc5433d7b71ea8939a0ac Reviewed-on: https://go-review.googlesource.com/c/go/+/199477 Run-TryBot: Minux Ma <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> (cherry picked from commit cfe2320) Reviewed-on: https://go-review.googlesource.com/c/go/+/200105 Run-TryBot: Alexander Rakoczy <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Cherry Zhang <[email protected]>
1 parent 81d995d commit 49073c5

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/os/os_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2254,8 +2254,6 @@ func TestPipeThreads(t *testing.T) {
22542254
t.Skip("skipping on Plan 9; does not support runtime poller")
22552255
case "js":
22562256
t.Skip("skipping on js; no support for os.Pipe")
2257-
case "darwin":
2258-
t.Skip("skipping on Darwin; issue 33953")
22592257
}
22602258

22612259
threads := 100

0 commit comments

Comments
 (0)