Skip to content

Commit 4858e8a

Browse files
committed
Add TODOs to fail test if merge fails
1 parent 4f8eb45 commit 4858e8a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/cmd/go/internal/test/test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1426,6 +1426,7 @@ func (c *runCache) builderRunTest(b *work.Builder, ctx context.Context, a *work.
14261426
t := fmt.Sprintf("%.3fs", time.Since(t0).Seconds())
14271427

14281428
if coverErr := mergeCoverProfile(tempCoverProfile); coverErr != nil {
1429+
// TODO: consider whether an error to merge cover profiles should fail the test.
14291430
fmt.Fprintf(cmd.Stdout, "error: %v\n", coverErr)
14301431
}
14311432

@@ -1671,6 +1672,7 @@ func (c *runCache) tryCacheWithID(b *work.Builder, a *work.Action, id string) bo
16711672
return false
16721673
}
16731674
if err := mergeCoverProfile(f); err != nil {
1675+
// TODO: consider whether an error to merge cover profiles should fail the test.
16741676
if cache.DebugTest {
16751677
fmt.Fprintf(os.Stderr, "testcache: %s: test coverage profile not merged: %v\n", a.Package.ImportPath, err)
16761678
}

0 commit comments

Comments
 (0)