Skip to content

Commit 4590abe

Browse files
committed
cmd/link: adjust whitelist for -strictdups checking for plan9
Add a couple of additional entries to the white list used to screen out errors for builtin functions; these correspond to cases that appear to come up only on the plan9 builder. Updates #31503. Change-Id: I48ab942ab2894240efe651ec7b7eace7aa5cb45e Reviewed-on: https://go-review.googlesource.com/c/go/+/172986 Reviewed-by: David du Colombier <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Than McIntosh <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 059f2d4 commit 4590abe

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/cmd/link/internal/objfile/objfile.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,9 @@ overwrite:
386386
// here is that we get different line numbers on formal
387387
// params; I am guessing that the pos is being inherited
388388
// from the spot where the wrapper is needed.
389-
whitelist := strings.HasPrefix(dup.Name, "go.info.go.interface")
389+
whitelist := (strings.HasPrefix(dup.Name, "go.info.go.interface") ||
390+
strings.HasPrefix(dup.Name, "go.info.go.builtin") ||
391+
strings.HasPrefix(dup.Name, "go.isstmt.go.builtin"))
390392
if !whitelist {
391393
r.strictDupMsgs++
392394
}

0 commit comments

Comments
 (0)