Skip to content

Commit 40765ff

Browse files
committed
os/exec: disable failing LookPathTest on windows/arm64
For #44379. Change-Id: I9a3cf4d511a8286117f877c2ff9dbde56fa55983 Reviewed-on: https://go-review.googlesource.com/c/go/+/293709 Reviewed-by: Cherry Zhang <[email protected]> Trust: Russ Cox <[email protected]>
1 parent b445d6e commit 40765ff

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

src/os/exec/lp_windows_test.go

+12-7
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ func (test lookPathTest) run(t *testing.T, tmpdir, printpathExe string) {
143143
if errCmd == nil && errLP == nil {
144144
// both succeeded
145145
if should != have {
146-
t.Fatalf("test=%+v failed: expected to find %q, but found %q", test, should, have)
146+
t.Fatalf("test=%+v:\ncmd /c ran: %s\nlookpath found: %s", test, should, have)
147147
}
148148
return
149149
}
@@ -316,12 +316,17 @@ func TestLookPath(t *testing.T) {
316316

317317
// Run all tests.
318318
for i, test := range lookPathTests {
319-
dir := filepath.Join(tmp, "d"+strconv.Itoa(i))
320-
err := os.Mkdir(dir, 0700)
321-
if err != nil {
322-
t.Fatal("Mkdir failed: ", err)
323-
}
324-
test.run(t, dir, printpathExe)
319+
t.Run(fmt.Sprint(i), func(t *testing.T) {
320+
if i == 16 {
321+
t.Skip("golang.org/issue/44379")
322+
}
323+
dir := filepath.Join(tmp, "d"+strconv.Itoa(i))
324+
err := os.Mkdir(dir, 0700)
325+
if err != nil {
326+
t.Fatal("Mkdir failed: ", err)
327+
}
328+
test.run(t, dir, printpathExe)
329+
})
325330
}
326331
}
327332

0 commit comments

Comments
 (0)