Skip to content

Commit 3e4afe2

Browse files
committed
syscall: skip test on TestUnshareMountNameSpace permission error
TestUnshareMountNameSpace fails on arm64 due to permission problems. Skip that test for now when permission problems are encountered, so we don't regress elsewhere in the meantime. Updates #19698 Change-Id: I9058928afa474b813652c9489f343b8957160a6c Reviewed-on: https://go-review.googlesource.com/39052 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Josh Bleecher Snyder <[email protected]>
1 parent 9ffbdab commit 3e4afe2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/syscall/exec_linux_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,10 @@ func TestUnshareMountNameSpace(t *testing.T) {
297297

298298
o, err := cmd.CombinedOutput()
299299
if err != nil {
300-
t.Fatalf("unshare failed: %v, %v", o, err)
300+
if strings.Contains(err.Error(), ": permission denied") {
301+
t.Skipf("Skipping test (golang.org/issue/19698); unshare failed due to permissions: %s, %v", o, err)
302+
}
303+
t.Fatalf("unshare failed: %s, %v", o, err)
301304
}
302305

303306
// How do we tell if the namespace was really unshared? It turns out

0 commit comments

Comments
 (0)