Skip to content

Commit 3853272

Browse files
ALTreeBryan C. Mills
authored and
Bryan C. Mills
committed
Revert "test: add regression test from #41474"
This reverts CL 263097. Reason for revert: broke the noopt builder. Change-Id: Ie36d2c3ed9449b4425732072db624c8e18f965f3 Reviewed-on: https://go-review.googlesource.com/c/go/+/263537 Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]> Trust: Alberto Donizetti <[email protected]>
1 parent 53094ac commit 3853272

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

src/os/os_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"errors"
1010
"flag"
1111
"fmt"
12-
"internal/race"
1312
"internal/testenv"
1413
"io"
1514
"io/ioutil"
@@ -2580,20 +2579,3 @@ func TestOpenFileKeepsPermissions(t *testing.T) {
25802579
t.Errorf("Stat after OpenFile is %v, should be writable", fi.Mode())
25812580
}
25822581
}
2583-
2584-
// Issue 41474.
2585-
func TestStdoutWriteDoesNotHeapAllocate(t *testing.T) {
2586-
if runtime.GOOS == "js" || runtime.GOOS == "windows" {
2587-
t.Skip("Still heap allocates on js/wasm and windows, but it used to too")
2588-
}
2589-
if race.Enabled {
2590-
t.Skip("Heap allocates in race mode")
2591-
}
2592-
2593-
n := testing.AllocsPerRun(10, func() {
2594-
Stdout.Write([]byte{'h', 'e', 'l', 'l', 'o', '\n'})
2595-
})
2596-
if n != 0 {
2597-
t.Errorf("AllocsPerRun = %v, want 0", n)
2598-
}
2599-
}

0 commit comments

Comments
 (0)