Skip to content

Commit 366f46f

Browse files
committed
runtime: remove TODO
I experimented with changing the write barrier to take the value in SI rather than AX to improve register allocation. It had no effect on performance and only made the "hello world" text 0.07% smaller, so let's just remove the comment. Change-Id: I6a261d14139b7a02a8467b31e74951dfb927ffb4 Reviewed-on: https://go-review.googlesource.com/78033 Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-by: Rick Hudson <[email protected]>
1 parent b44b2fe commit 366f46f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/runtime/asm_amd64.s

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2379,8 +2379,6 @@ TEXT runtime·addmoduledata(SB),NOSPLIT,$0-0
23792379
// - AX is the value being written at DI
23802380
// It clobbers FLAGS. It does not clobber any general-purpose registers,
23812381
// but may clobber others (e.g., SSE registers).
2382-
//
2383-
// TODO: AX may be a bad choice because regalloc likes to use it.
23842382
TEXT runtime·gcWriteBarrier(SB),NOSPLIT,$120
23852383
// Save the registers clobbered by the fast path.
23862384
//

0 commit comments

Comments
 (0)