Skip to content

Commit 31cabcf

Browse files
FiloSottilegopherbot
authored andcommitted
crypto/internal/fips140: mark OpenBSD unsupported
Since OpenBSD 7.3, external linking uses -fexecute-only, which breaks the integrity check. Since we are not validating on OpenBSD anyway, mark it as unsupported at least for now. Fixes #70880 Change-Id: I6a6a4656b6c7a97c0962b4158d920f9e6b19678e Reviewed-on: https://go-review.googlesource.com/c/go/+/639337 Auto-Submit: Filippo Valsorda <[email protected]> Reviewed-by: Daniel McCarney <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Joel Sing <[email protected]> Reviewed-by: صادق <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent eb0c2b2 commit 31cabcf

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/cmd/dist/test.go

+1
Original file line numberDiff line numberDiff line change
@@ -1812,6 +1812,7 @@ func (t *tester) fipsSupported() bool {
18121812
case goarch == "wasm",
18131813
goos == "windows" && goarch == "386",
18141814
goos == "windows" && goarch == "arm",
1815+
goos == "openbsd",
18151816
goos == "aix":
18161817
return false
18171818
}

src/crypto/internal/fips140/fips140.go

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ func Supported() error {
4646
case runtime.GOARCH == "wasm",
4747
runtime.GOOS == "windows" && runtime.GOARCH == "386",
4848
runtime.GOOS == "windows" && runtime.GOARCH == "arm",
49+
runtime.GOOS == "openbsd", // due to -fexecute-only, see #70880
4950
runtime.GOOS == "aix":
5051
return errors.New("FIPS 140-3 mode is not supported on " + runtime.GOOS + "-" + runtime.GOARCH)
5152
}

0 commit comments

Comments
 (0)