Skip to content

Commit 2cde950

Browse files
prattmicgopherbot
authored andcommitted
runtime: disable TestSegv in race mode
This was just enabled in CL 643897. It seems to work fine on Linux, but there are traceback issues on Darwin. We could disable just on Darwin, but I'm not sure SIGSEGV inside of TSAN is something we care to support. Fixes #73784. Cq-Include-Trybots: luci.golang.try:gotip-darwin-arm64-race Change-Id: I6a6a636cb15d7affaeb22c4c13d8f2a5c9bb31fd Reviewed-on: https://go-review.googlesource.com/c/go/+/674276 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Auto-Submit: Michael Pratt <[email protected]>
1 parent fd6afa3 commit 2cde950

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/runtime/crash_cgo_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -659,8 +659,8 @@ func TestSegv(t *testing.T) {
659659
case "plan9", "windows":
660660
t.Skipf("no signals on %s", runtime.GOOS)
661661
}
662-
if asan.Enabled || msan.Enabled {
663-
t.Skip("skipping test on ASAN/MSAN: triggers SIGSEGV in sanitizer runtime")
662+
if race.Enabled || asan.Enabled || msan.Enabled {
663+
t.Skip("skipping test on race/ASAN/MSAN: triggers SIGSEGV in sanitizer runtime")
664664
}
665665

666666
for _, test := range []string{"Segv", "SegvInCgo", "TgkillSegv", "TgkillSegvInCgo"} {

0 commit comments

Comments
 (0)