Skip to content

Commit 27a3d30

Browse files
committed
net/http: deflake TestClientRedirects
Fix another case of a parallel test relying on a global variable (DefaultTransport) implicitly. Use the private Transport already in scope instead. It's closed at the end, instead of randomly via another test. Change-Id: I95e51926177ad19a766cabbb306782ded1bbb59b Reviewed-on: https://go-review.googlesource.com/32913 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 41eb9bb commit 27a3d30

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/net/http/client_test.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,14 @@ func TestClientRedirects(t *testing.T) {
251251
var checkErr error
252252
var lastVia []*Request
253253
var lastReq *Request
254-
c = &Client{CheckRedirect: func(req *Request, via []*Request) error {
255-
lastReq = req
256-
lastVia = via
257-
return checkErr
258-
}}
254+
c = &Client{
255+
Transport: tr,
256+
CheckRedirect: func(req *Request, via []*Request) error {
257+
lastReq = req
258+
lastVia = via
259+
return checkErr
260+
},
261+
}
259262
res, err := c.Get(ts.URL)
260263
if err != nil {
261264
t.Fatalf("Get error: %v", err)

0 commit comments

Comments
 (0)