Skip to content

Commit 244ccf4

Browse files
committed
Revert "cmd/go: add telemetry counters for flag names and subcommand"
This reverts CL 559519. Reason for revert: Broke windows/386. See https://build.golang.org/log/03594b706c425bd61fb3c65495aae6dd01b4a81b. Fixes #65447. Change-Id: I567bca0368168dbfb256fadba37bce3cd31aceb2 Reviewed-on: https://go-review.googlesource.com/c/go/+/560655 Reviewed-by: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 117164f commit 244ccf4

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/cmd/go/main.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ func main() {
9797

9898
flag.Usage = base.Usage
9999
flag.Parse()
100-
counter.CountFlags("cmd/go:flag-", *flag.CommandLine)
101100

102101
args := flag.Args()
103102
if len(args) < 1 {
@@ -153,7 +152,6 @@ func main() {
153152

154153
cmd, used := lookupCmd(args)
155154
cfg.CmdName = strings.Join(args[:used], " ")
156-
counter.Inc("cmd/go:subcommand-" + strings.ReplaceAll(cfg.CmdName, " ", "-"))
157155
if len(cmd.Commands) > 0 {
158156
if used >= len(args) {
159157
help.PrintUsage(os.Stderr, cmd)
@@ -241,7 +239,6 @@ func invoke(cmd *base.Command, args []string) {
241239
} else {
242240
base.SetFromGOFLAGS(&cmd.Flag)
243241
cmd.Flag.Parse(args[1:])
244-
counter.CountFlags("cmd/go/"+cmd.Name()+":flag-", cmd.Flag)
245242
args = cmd.Flag.Args()
246243
}
247244

@@ -326,7 +323,6 @@ func handleChdirFlag() {
326323
_, dir, _ = strings.Cut(a, "=")
327324
os.Args = slices.Delete(os.Args, used, used+1)
328325
}
329-
counter.Inc("cmd/go:flag-C")
330326

331327
if err := os.Chdir(dir); err != nil {
332328
base.Fatalf("go: %v", err)

0 commit comments

Comments
 (0)