Skip to content

Commit 20e9b7f

Browse files
committed
debug/dwarf: return ErrUnknownPC rather than nil on unknown PC
Currently, on e == nil or e.Tag == 0, SeekPC returns with a nil error. Instead, indicate that the PC is unknown. Change-Id: I9594296034e2df872e399bd800b00cb565c413c9 Reviewed-on: https://go-review.googlesource.com/c/go/+/473695 Reviewed-by: Carlos Amedee <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]>
1 parent 6827f0d commit 20e9b7f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/debug/dwarf/entry.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -975,9 +975,12 @@ func (r *Reader) SeekPC(pc uint64) (*Entry, error) {
975975
u := &r.d.unit[unit]
976976
r.b = makeBuf(r.d, u, "info", u.off, u.data)
977977
e, err := r.Next()
978-
if err != nil || e == nil || e.Tag == 0 {
978+
if err != nil {
979979
return nil, err
980980
}
981+
if e == nil || e.Tag == 0 {
982+
return nil, ErrUnknownPC
983+
}
981984
ranges, err := r.d.Ranges(e)
982985
if err != nil {
983986
return nil, err

0 commit comments

Comments
 (0)