Skip to content

Commit 209dd4c

Browse files
committed
test: fix windows build
Broken by e7173df Fix by simply disabling the relevant tests. * bug248 and bug345 require errchk, but we can't rely on perl being available. * bug369 is disabled anyway. Change-Id: Idf73ebccb066943e3fe17c2f662b37238ec74dfe Reviewed-on: https://go-review.googlesource.com/2052 Reviewed-by: Alex Brainman <[email protected]>
1 parent 53c5226 commit 209dd4c

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

test/fixedbugs/bug248.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// +build !nacl
1+
// +build !nacl,!windows
22
// run
33

44
// Copyright 2009 The Go Authors. All rights reserved.
@@ -19,6 +19,7 @@ func main() {
1919
a, err := build.ArchChar(build.Default.GOARCH)
2020
check(err)
2121

22+
// TODO: If we get rid of errchk, re-enable this test on Windows.
2223
errchk, err := filepath.Abs("errchk")
2324
check(err)
2425

test/fixedbugs/bug345.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// +build !nacl
1+
// +build !nacl,!windows
22
// run
33

44
// Copyright 2011 The Go Authors. All rights reserved.
@@ -19,6 +19,7 @@ func main() {
1919
a, err := build.ArchChar(build.Default.GOARCH)
2020
check(err)
2121

22+
// TODO: If we get rid of errchk, re-enable this test on Windows.
2223
errchk, err := filepath.Abs("errchk")
2324
check(err)
2425

test/fixedbugs/bug369.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// +build !nacl
1+
// +build !nacl,!windows
22
// run
33

44
// Copyright 2011 The Go Authors. All rights reserved.

0 commit comments

Comments
 (0)