Skip to content

Commit 182bdbb

Browse files
josharianbradfitz
authored andcommitted
[release-branch.go1.4] all.bash: skip tests by default
The 1.4 tests aren't necessarily supposed to pass. Disable them by default, to avoid the sort of unpleasant experience described in #25816. Change-Id: I763b8e52c8d16f4d9be14ad853df456652e51430 Reviewed-on: https://go-review.googlesource.com/124077 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 94221a0 commit 182bdbb

File tree

3 files changed

+15
-0
lines changed

3 files changed

+15
-0
lines changed

src/all.bash

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ if [ ! -f make.bash ]; then
1010
fi
1111
OLDPATH="$PATH"
1212
. ./make.bash "$@" --no-banner
13+
if [ "$GO14TESTS" != "1" ]; then
14+
echo "Build complete; skipping tests."
15+
echo "To force tests, set GO14TESTS=1 and re-run, but expect some failures."
16+
exit
17+
fi
1318
bash run.bash --no-rebuild
1419
PATH="$OLDPATH"
1520
$GOTOOLDIR/dist banner # print build info

src/all.bat

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ goto end
1414
set OLDPATH=%PATH%
1515
call make.bat --no-banner --no-local
1616
if %GOBUILDFAIL%==1 goto end
17+
if x%GO14TESTS%==x1 goto runtests
18+
echo Build complete; skipping tests.
19+
echo To force tests, set GO14TESTS=1 and re-run, but expect some failures.
20+
goto end
21+
:runtests
1722
call run.bat --no-rebuild --no-local
1823
if %GOBUILDFAIL%==1 goto end
1924
:: we must restore %PATH% before running "dist banner" so that the latter

src/all.rc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ if(! test -f make.rc){
1111
}
1212

1313
. ./make.rc --no-banner
14+
if(~ $GO14TESTS ''){
15+
echo 'Build complete; skipping tests.'
16+
echo 'To force tests, set GO14TESTS = 1 and re-run, but expect some failures.'
17+
exit
18+
}
1419
bind -b $GOROOT/bin /bin
1520
./run.rc --no-rebuild
1621
$GOTOOLDIR/dist banner # print build info

0 commit comments

Comments
 (0)