Skip to content

Commit 168eb9c

Browse files
Jeff Wendlingbradfitz
Jeff Wendling
authored andcommitted
cmd/dist: disable plugin test on linux-arm with GOARM=5
Plugin support is patchy at the moment, so disable the test for now until the test can be fixed. This way, we can get builders for ARMv5 running for the rest of the code. Updates #19674 Change-Id: I08aa211c08a85688656afe2ad2e680a2a6e5dfac Reviewed-on: https://go-review.googlesource.com/39716 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 4e7724b commit 168eb9c

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/cmd/dist/test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ type tester struct {
5959
goroot string
6060
goarch string
6161
gohostarch string
62+
goarm string
6263
goos string
6364
gohostos string
6465
cgoEnabled bool
@@ -102,6 +103,7 @@ func (t *tester) run() {
102103
t.gohostos = mustEnv("GOHOSTOS")
103104
t.goarch = mustEnv("GOARCH")
104105
t.gohostarch = mustEnv("GOHOSTARCH")
106+
t.goarm = os.Getenv("GOARM")
105107
slurp, err := exec.Command("go", "env", "CGO_ENABLED").Output()
106108
if err != nil {
107109
log.Fatalf("Error running go env CGO_ENABLED: %v", err)
@@ -782,6 +784,12 @@ func (t *tester) supportedBuildmode(mode string) bool {
782784
return false
783785
}
784786

787+
if pair == "linux-arm" && t.goarm == "5" {
788+
// Skip the plugin tests for now on ARMv5 because it causes a
789+
// SIGILL. See https://golang.org/issue/19674
790+
return false
791+
}
792+
785793
// linux-arm64 is missing because it causes the external linker
786794
// to crash, see https://golang.org/issue/17138
787795
switch pair {

0 commit comments

Comments
 (0)