Skip to content

Commit 1587c36

Browse files
Bryan C. Millsgopherbot
Bryan C. Mills
authored andcommitted
runtime: check for ErrWaitDelay in runBuiltTestProg
ErrWaitDelay is not expected to occur in this test, but if it does it indicates a failure mode very different from the “failed to start” catchall that we log for other non-ExitError errors. Updates #50436. Change-Id: I3f4d87d502f772bf471fc17303d5a6b483446f8f Reviewed-on: https://go-review.googlesource.com/c/go/+/446876 Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]>
1 parent 082afcc commit 1587c36

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/runtime/crash_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ func runBuiltTestProg(t *testing.T, exe, name string, env ...string) string {
7777
if err != nil {
7878
if _, ok := err.(*exec.ExitError); ok {
7979
t.Logf("%v: %v", cmd, err)
80+
} else if errors.Is(err, exec.ErrWaitDelay) {
81+
t.Fatalf("%v: %v", cmd, err)
8082
} else {
8183
t.Fatalf("%v failed to start: %v", cmd, err)
8284
}

0 commit comments

Comments
 (0)