Skip to content

Commit 14e9f48

Browse files
mvdanianlancetaylor
authored andcommitted
cmd/cover: don't ignore os.Create error
Failing to create the output file would give confusing errors such as: cover: invalid argument Also do out.Close() even if Execute() errored. Fixes #17951. Change-Id: I897e1d31f7996871c54fde7cb09614cafbf6c3fc Reviewed-on: https://go-review.googlesource.com/33278 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]>
1 parent d7c0de9 commit 14e9f48

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/cmd/cover/html.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,12 @@ func htmlOutput(profile, outfile string) error {
6464
} else {
6565
out, err = os.Create(outfile)
6666
}
67+
if err != nil {
68+
return err
69+
}
6770
err = htmlTemplate.Execute(out, d)
68-
if err == nil {
69-
err = out.Close()
71+
if err2 := out.Close(); err == nil {
72+
err = err2
7073
}
7174
if err != nil {
7275
return err

0 commit comments

Comments
 (0)