Skip to content

Commit 123594d

Browse files
xiaostgopherbot
authored andcommitted
runtime: remove cloudwego/frugal unused linkname from comment
frugal no longer uses these methods from next Go version Fixes #69222 Change-Id: Ie71de0752cabef7d5584d3392d6e5920ba742350 Reviewed-on: https://go-review.googlesource.com/c/go/+/609918 Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Austin Clements <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 9e9b1f5 commit 123594d

11 files changed

+1
-111
lines changed

src/runtime/alg.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ func memhash64(p unsafe.Pointer, h uintptr) uintptr
9797
// - github.com/aristanetworks/goarista
9898
// - github.com/bytedance/sonic
9999
// - github.com/bytedance/go-tagexpr/v2
100-
// - github.com/cloudwego/frugal
101100
// - github.com/cloudwego/dynamicgo
102101
// - github.com/v2fly/v2ray-core/v5
103102
//

src/runtime/map_fast32_noswiss.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ func mapaccess2_fast32(t *maptype, h *hmap, key uint32) (unsafe.Pointer, bool) {
105105
// but widely used packages access it using linkname.
106106
// Notable members of the hall of shame include:
107107
// - github.com/bytedance/sonic
108-
// - github.com/cloudwego/frugal
109108
// - github.com/ugorji/go/codec
110109
//
111110
// Do not remove or change the type signature.

src/runtime/map_fast64_noswiss.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ func mapaccess2_fast64(t *maptype, h *hmap, key uint64) (unsafe.Pointer, bool) {
105105
// but widely used packages access it using linkname.
106106
// Notable members of the hall of shame include:
107107
// - github.com/bytedance/sonic
108-
// - github.com/cloudwego/frugal
109108
// - github.com/ugorji/go/codec
110109
//
111110
// Do not remove or change the type signature.
@@ -206,7 +205,6 @@ done:
206205
// but widely used packages access it using linkname.
207206
// Notable members of the hall of shame include:
208207
// - github.com/bytedance/sonic
209-
// - github.com/cloudwego/frugal
210208
// - github.com/ugorji/go/codec
211209
//
212210
// Do not remove or change the type signature.

src/runtime/map_faststr_noswiss.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ dohash:
215215
// but widely used packages access it using linkname.
216216
// Notable members of the hall of shame include:
217217
// - github.com/bytedance/sonic
218-
// - github.com/cloudwego/frugal
219218
// - github.com/ugorji/go/codec
220219
//
221220
// Do not remove or change the type signature.

src/runtime/map_noswiss.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,6 @@ func makemap_small() *hmap {
312312
// makemap should be an internal detail,
313313
// but widely used packages access it using linkname.
314314
// Notable members of the hall of shame include:
315-
// - github.com/cloudwego/frugal
316315
// - github.com/ugorji/go/codec
317316
//
318317
// Do not remove or change the type signature.
@@ -607,7 +606,6 @@ func mapaccess2_fat(t *maptype, h *hmap, key, zero unsafe.Pointer) (unsafe.Point
607606
// but widely used packages access it using linkname.
608607
// Notable members of the hall of shame include:
609608
// - github.com/bytedance/sonic
610-
// - github.com/cloudwego/frugal
611609
// - github.com/RomiChan/protobuf
612610
// - github.com/segmentio/encoding
613611
// - github.com/ugorji/go/codec
@@ -867,7 +865,6 @@ search:
867865
// but widely used packages access it using linkname.
868866
// Notable members of the hall of shame include:
869867
// - github.com/bytedance/sonic
870-
// - github.com/cloudwego/frugal
871868
// - github.com/goccy/go-json
872869
// - github.com/RomiChan/protobuf
873870
// - github.com/segmentio/encoding
@@ -928,7 +925,6 @@ func mapiterinit(t *maptype, h *hmap, it *hiter) {
928925
// but widely used packages access it using linkname.
929926
// Notable members of the hall of shame include:
930927
// - github.com/bytedance/sonic
931-
// - github.com/cloudwego/frugal
932928
// - github.com/RomiChan/protobuf
933929
// - github.com/segmentio/encoding
934930
// - github.com/ugorji/go/codec
@@ -1066,16 +1062,6 @@ next:
10661062

10671063
// mapclear deletes all keys from a map.
10681064
// It is called by the compiler.
1069-
//
1070-
// mapclear should be an internal detail,
1071-
// but widely used packages access it using linkname.
1072-
// Notable members of the hall of shame include:
1073-
// - github.com/cloudwego/frugal
1074-
//
1075-
// Do not remove or change the type signature.
1076-
// See go.dev/issue/67401.
1077-
//
1078-
//go:linkname mapclear
10791065
func mapclear(t *maptype, h *hmap) {
10801066
if raceenabled && h != nil {
10811067
callerpc := getcallerpc()

src/runtime/mgc.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ var gcphase uint32
220220
// but widely used packages access it using linkname.
221221
// Notable members of the hall of shame include:
222222
// - github.com/bytedance/sonic
223-
// - github.com/cloudwego/frugal
224223
//
225224
// Do not remove or change the type signature.
226225
// See go.dev/issue/67401.

src/runtime/runtime1.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,6 @@ func reflect_resolveTypeOff(rtype unsafe.Pointer, off int32) unsafe.Pointer {
680680
// reflect_resolveTextOff is for package reflect,
681681
// but widely used packages access it using linkname.
682682
// Notable members of the hall of shame include:
683-
// - github.com/cloudwego/frugal
684683
// - github.com/agiledragon/gomonkey/v2
685684
//
686685
// Do not remove or change the type signature.

src/runtime/string.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,6 @@ func concatstring5(buf *tmpBuf, a0, a1, a2, a3, a4 string) string {
7878
// n is the length of the slice.
7979
// Buf is a fixed-size buffer for the result,
8080
// it is not nil if the result does not escape.
81-
//
82-
// slicebytetostring should be an internal detail,
83-
// but widely used packages access it using linkname.
84-
// Notable members of the hall of shame include:
85-
// - github.com/cloudwego/frugal
86-
//
87-
// Do not remove or change the type signature.
88-
// See go.dev/issue/67401.
89-
//
90-
//go:linkname slicebytetostring
9181
func slicebytetostring(buf *tmpBuf, ptr *byte, n int) string {
9282
if n == 0 {
9383
// Turns out to be a relatively common case.

src/runtime/stubs.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ func badsystemstack() {
9797
// Notable members of the hall of shame include:
9898
// - github.com/bytedance/sonic
9999
// - github.com/chenzhuoyu/iasm
100-
// - github.com/cloudwego/frugal
101100
// - github.com/dgraph-io/ristretto
102101
// - github.com/outcaste-io/ristretto
103102
//
@@ -132,7 +131,6 @@ func reflect_memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr) {
132131
// Notable members of the hall of shame include:
133132
// - github.com/bytedance/sonic
134133
// - github.com/cloudwego/dynamicgo
135-
// - github.com/cloudwego/frugal
136134
// - github.com/ebitengine/purego
137135
// - github.com/tetratelabs/wazero
138136
// - github.com/ugorji/go/codec
@@ -365,15 +363,6 @@ func asmcgocall(fn, arg unsafe.Pointer) int32
365363

366364
func morestack()
367365

368-
// morestack_noctxt should be an internal detail,
369-
// but widely used packages access it using linkname.
370-
// Notable members of the hall of shame include:
371-
// - github.com/cloudwego/frugal
372-
//
373-
// Do not remove or change the type signature.
374-
// See go.dev/issue/67401.
375-
//
376-
//go:linkname morestack_noctxt
377366
func morestack_noctxt()
378367

379368
func rt0_go()
@@ -465,7 +454,6 @@ func gcWriteBarrier1()
465454
// but widely used packages access it using linkname.
466455
// Notable members of the hall of shame include:
467456
// - github.com/bytedance/sonic
468-
// - github.com/cloudwego/frugal
469457
//
470458
// Do not remove or change the type signature.
471459
// See go.dev/issue/67401.

src/runtime/symtab.go

Lines changed: 1 addition & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -462,17 +462,7 @@ type modulehash struct {
462462
// To make sure the map isn't collected, we keep a second reference here.
463463
var pinnedTypemaps []map[typeOff]*_type
464464

465-
var firstmoduledata moduledata // linker symbol
466-
467-
// lastmoduledatap should be an internal detail,
468-
// but widely used packages access it using linkname.
469-
// Notable members of the hall of shame include:
470-
// - github.com/cloudwego/frugal
471-
//
472-
// Do not remove or change the type signature.
473-
// See go.dev/issue/67401.
474-
//
475-
//go:linkname lastmoduledatap
465+
var firstmoduledata moduledata // linker symbol
476466
var lastmoduledatap *moduledata // linker symbol
477467

478468
var modulesSlice *[]*moduledata // see activeModules
@@ -583,15 +573,6 @@ func moduledataverify() {
583573

584574
const debugPcln = false
585575

586-
// moduledataverify1 should be an internal detail,
587-
// but widely used packages access it using linkname.
588-
// Notable members of the hall of shame include:
589-
// - github.com/cloudwego/frugal
590-
//
591-
// Do not remove or change the type signature.
592-
// See go.dev/issue/67401.
593-
//
594-
//go:linkname moduledataverify1
595576
func moduledataverify1(datap *moduledata) {
596577
// Check that the pclntab's format is valid.
597578
hdr := datap.pcHeader
@@ -862,7 +843,6 @@ func badFuncInfoEntry(funcInfo) uintptr
862843
// findfunc should be an internal detail,
863844
// but widely used packages access it using linkname.
864845
// Notable members of the hall of shame include:
865-
// - github.com/cloudwego/frugal
866846
// - github.com/phuslu/log
867847
//
868848
// Do not remove or change the type signature.
@@ -1196,16 +1176,6 @@ func pcdatavalue1(f funcInfo, table uint32, targetpc uintptr, strict bool) int32
11961176
}
11971177

11981178
// Like pcdatavalue, but also return the start PC of this PCData value.
1199-
//
1200-
// pcdatavalue2 should be an internal detail,
1201-
// but widely used packages access it using linkname.
1202-
// Notable members of the hall of shame include:
1203-
// - github.com/cloudwego/frugal
1204-
//
1205-
// Do not remove or change the type signature.
1206-
// See go.dev/issue/67401.
1207-
//
1208-
//go:linkname pcdatavalue2
12091179
func pcdatavalue2(f funcInfo, table uint32, targetpc uintptr) (int32, uintptr) {
12101180
if table >= f.npcdata {
12111181
return -1, 0
@@ -1234,16 +1204,6 @@ func funcdata(f funcInfo, i uint8) unsafe.Pointer {
12341204
}
12351205

12361206
// step advances to the next pc, value pair in the encoded table.
1237-
//
1238-
// step should be an internal detail,
1239-
// but widely used packages access it using linkname.
1240-
// Notable members of the hall of shame include:
1241-
// - github.com/cloudwego/frugal
1242-
//
1243-
// Do not remove or change the type signature.
1244-
// See go.dev/issue/67401.
1245-
//
1246-
//go:linkname step
12471207
func step(p []byte, pc *uintptr, val *int32, first bool) (newp []byte, ok bool) {
12481208
// For both uvdelta and pcdelta, the common case (~70%)
12491209
// is that they are a single byte. If so, avoid calling readvarint.
@@ -1289,15 +1249,6 @@ type stackmap struct {
12891249
bytedata [1]byte // bitmaps, each starting on a byte boundary
12901250
}
12911251

1292-
// stackmapdata should be an internal detail,
1293-
// but widely used packages access it using linkname.
1294-
// Notable members of the hall of shame include:
1295-
// - github.com/cloudwego/frugal
1296-
//
1297-
// Do not remove or change the type signature.
1298-
// See go.dev/issue/67401.
1299-
//
1300-
//go:linkname stackmapdata
13011252
//go:nowritebarrier
13021253
func stackmapdata(stkmap *stackmap, n int32) bitvector {
13031254
// Check this invariant only when stackDebug is on at all.

src/runtime/type.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,6 @@ func reflectOffsUnlock() {
107107
unlock(&reflectOffs.lock)
108108
}
109109

110-
// resolveNameOff should be an internal detail,
111-
// but widely used packages access it using linkname.
112-
// Notable members of the hall of shame include:
113-
// - github.com/cloudwego/frugal
114-
//
115-
// Do not remove or change the type signature.
116-
// See go.dev/issue/67401.
117-
//
118-
//go:linkname resolveNameOff
119110
func resolveNameOff(ptrInModule unsafe.Pointer, off nameOff) name {
120111
if off == 0 {
121112
return name{}
@@ -150,15 +141,6 @@ func (t rtype) nameOff(off nameOff) name {
150141
return resolveNameOff(unsafe.Pointer(t.Type), off)
151142
}
152143

153-
// resolveTypeOff should be an internal detail,
154-
// but widely used packages access it using linkname.
155-
// Notable members of the hall of shame include:
156-
// - github.com/cloudwego/frugal
157-
//
158-
// Do not remove or change the type signature.
159-
// See go.dev/issue/67401.
160-
//
161-
//go:linkname resolveTypeOff
162144
func resolveTypeOff(ptrInModule unsafe.Pointer, off typeOff) *_type {
163145
if off == 0 || off == -1 {
164146
// -1 is the sentinel value for unreachable code.

0 commit comments

Comments
 (0)