crypto/x509: Include OID in duplicate extension error message

Techassi · Techassi · commit 0ed2f97fbd0d · 2024-05-03T16:46:31.000+02:00
diff --git a/src/crypto/x509/parser.go b/src/crypto/x509/parser.go
@@ -964,7 +964,7 @@ func parseCertificate(der []byte) (*Certificate, error) {
 					}
 					oidStr := ext.Id.String()
 					if seenExts[oidStr] {
-						return nil, errors.New("x509: certificate contains duplicate extensions")
+						return nil, errors.New("x509: certificate contains duplicate extension %s", oidStr)
 					}
 					seenExts[oidStr] = true
 					cert.Extensions = append(cert.Extensions, ext)

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,7 @@ func parseCertificate(der []byte) (*Certificate, error) {`
`964`	`964`	`}`
`965`	`965`	`oidStr := ext.Id.String()`
`966`	`966`	`if seenExts[oidStr] {`
`967`		`- return nil, errors.New("x509: certificate contains duplicate extensions")`
	`967`	`+ return nil, errors.New("x509: certificate contains duplicate extension %s", oidStr)`
`968`	`968`	`}`
`969`	`969`	`seenExts[oidStr] = true`
`970`	`970`	`cert.Extensions = append(cert.Extensions, ext)`