Skip to content

Commit 0ca521f

Browse files
ianlancetaylorgopherbot
authored andcommitted
debug/elf: adjust version API per issue discussion
This updates the new version API for the discussion on #63952. This change reveals that in fact none of the tests set the VERSYM_HIDDEN bit. The code before this CL set the hidden flag for symbols that appear in DynamicVersionNeed, but that is not an accurate representation of the ELF. The readelf program does print undefined symbols that way (with a single '@'), but that doesn't mean that the hidden flag is set. Leaving tests with the hidden bit set for later. For #63952 Change-Id: Ida60831e0c9922dfc10f10c7a64bc76a2b197537 Reviewed-on: https://go-review.googlesource.com/c/go/+/635079 Reviewed-by: Austin Clements <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent c93477b commit 0ca521f

File tree

4 files changed

+440
-391
lines changed

4 files changed

+440
-391
lines changed

api/go1.24.txt

+14-13
Original file line numberDiff line numberDiff line change
@@ -106,33 +106,34 @@ pkg debug/elf, const VER_FLG_INFO = 4 #63952
106106
pkg debug/elf, const VER_FLG_INFO DynamicVersionFlag #63952
107107
pkg debug/elf, const VER_FLG_WEAK = 2 #63952
108108
pkg debug/elf, const VER_FLG_WEAK DynamicVersionFlag #63952
109-
pkg debug/elf, const VerFlagGlobal = 2 #63952
110-
pkg debug/elf, const VerFlagGlobal SymbolVersionFlag #63952
111-
pkg debug/elf, const VerFlagHidden = 4 #63952
112-
pkg debug/elf, const VerFlagHidden SymbolVersionFlag #63952
113-
pkg debug/elf, const VerFlagLocal = 1 #63952
114-
pkg debug/elf, const VerFlagLocal SymbolVersionFlag #63952
115-
pkg debug/elf, const VerFlagNone = 0 #63952
116-
pkg debug/elf, const VerFlagNone SymbolVersionFlag #63952
109+
pkg debug/elf, const VersionScopeGlobal = 2 #63952
110+
pkg debug/elf, const VersionScopeGlobal SymbolVersionScope #63952
111+
pkg debug/elf, const VersionScopeHidden = 4 #63952
112+
pkg debug/elf, const VersionScopeHidden SymbolVersionScope #63952
113+
pkg debug/elf, const VersionScopeLocal = 1 #63952
114+
pkg debug/elf, const VersionScopeLocal SymbolVersionScope #63952
115+
pkg debug/elf, const VersionScopeNone = 0 #63952
116+
pkg debug/elf, const VersionScopeNone SymbolVersionScope #63952
117+
pkg debug/elf, const VersionScopeSpecific = 3 #63952
118+
pkg debug/elf, const VersionScopeSpecific SymbolVersionScope #63952
117119
pkg debug/elf, method (*File) DynamicVersionNeeds() ([]DynamicVersionNeed, error) #63952
118120
pkg debug/elf, method (*File) DynamicVersions() ([]DynamicVersion, error) #63952
119121
pkg debug/elf, type DynamicVersion struct #63952
120122
pkg debug/elf, type DynamicVersion struct, Deps []string #63952
121123
pkg debug/elf, type DynamicVersion struct, Flags DynamicVersionFlag #63952
124+
pkg debug/elf, type DynamicVersion struct, Name string #63952
122125
pkg debug/elf, type DynamicVersion struct, Index uint16 #63952
123-
pkg debug/elf, type DynamicVersion struct, Version uint16 #63952
124126
pkg debug/elf, type DynamicVersionDep struct #63952
125127
pkg debug/elf, type DynamicVersionDep struct, Dep string #63952
126128
pkg debug/elf, type DynamicVersionDep struct, Flags DynamicVersionFlag #63952
127-
pkg debug/elf, type DynamicVersionDep struct, Other uint16 #63952
129+
pkg debug/elf, type DynamicVersionDep struct, Index uint16 #63952
128130
pkg debug/elf, type DynamicVersionFlag uint16 #63952
129131
pkg debug/elf, type DynamicVersionNeed struct #63952
130132
pkg debug/elf, type DynamicVersionNeed struct, Name string #63952
131133
pkg debug/elf, type DynamicVersionNeed struct, Needs []DynamicVersionDep #63952
132-
pkg debug/elf, type DynamicVersionNeed struct, Version uint16 #63952
133-
pkg debug/elf, type Symbol struct, VersionFlags SymbolVersionFlag #63952
134+
pkg debug/elf, type Symbol struct, VersionScope SymbolVersionScope #63952
134135
pkg debug/elf, type Symbol struct, VersionIndex int16 #63952
135-
pkg debug/elf, type SymbolVersionFlag uint8 #63952
136+
pkg debug/elf, type SymbolVersionScope uint8 #63952
136137
pkg encoding, type BinaryAppender interface { AppendBinary } #62384
137138
pkg encoding, type BinaryAppender interface, AppendBinary([]uint8) ([]uint8, error) #62384
138139
pkg encoding, type TextAppender interface { AppendText } #62384

0 commit comments

Comments
 (0)