Skip to content

Commit 023593d

Browse files
Vladimir Stefanovicbradfitz
Vladimir Stefanovic
authored andcommitted
runtime: enable GDB tests on mips64 (except TestGdbPythonCgo)
They were failing when run on 32bit RFS, with 32bit gdb. (mips64 builder now has 64bit RFS, with gdb 7.9.) Leaving TestGdbPythonCgo disabled, it behaves as described in #18784. Fixes #18173 Change-Id: I3c438cd5850b7bfd118ac6396f40c1208bac8c2d Reviewed-on: https://go-review.googlesource.com/45874 Reviewed-by: Cherry Zhang <[email protected]> Run-TryBot: Cherry Zhang <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent e7c650b commit 023593d

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

src/runtime/runtime-gdb_test.go

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,16 +91,13 @@ func TestGdbPython(t *testing.T) {
9191
}
9292

9393
func TestGdbPythonCgo(t *testing.T) {
94-
if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" {
94+
if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" || runtime.GOARCH == "mips64" {
9595
testenv.SkipFlaky(t, 18784)
9696
}
9797
testGdbPython(t, true)
9898
}
9999

100100
func testGdbPython(t *testing.T, cgo bool) {
101-
if runtime.GOARCH == "mips64" {
102-
testenv.SkipFlaky(t, 18173)
103-
}
104101
if cgo && !build.Default.CgoEnabled {
105102
t.Skip("skipping because cgo is not enabled")
106103
}
@@ -258,9 +255,6 @@ func TestGdbBacktrace(t *testing.T) {
258255
if runtime.GOOS == "netbsd" {
259256
testenv.SkipFlaky(t, 15603)
260257
}
261-
if runtime.GOARCH == "mips64" {
262-
testenv.SkipFlaky(t, 18173)
263-
}
264258

265259
t.Parallel()
266260
checkGdbEnvironment(t)
@@ -332,10 +326,6 @@ func main() {
332326
// TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info
333327
// See bug #17830.
334328
func TestGdbAutotmpTypes(t *testing.T) {
335-
if runtime.GOARCH == "mips64" {
336-
testenv.SkipFlaky(t, 18173)
337-
}
338-
339329
t.Parallel()
340330
checkGdbEnvironment(t)
341331
checkGdbVersion(t)

0 commit comments

Comments
 (0)