Skip to content
This repository was archived by the owner on Jan 16, 2021. It is now read-only.

update Source-Code-Links Wiki #417

Closed
dmitris opened this issue Jun 21, 2016 · 1 comment
Closed

update Source-Code-Links Wiki #417

dmitris opened this issue Jun 21, 2016 · 1 comment

Comments

@dmitris
Copy link
Contributor

dmitris commented Jun 21, 2016

https://github.com/golang/gddo/wiki/Source-Code-Links lists several rules that must be followed until the implementation is fixed (see #385) - however, #385 is fixed and closed, we probably should update the Wiki accordingly.

@shurcooL

@dmitshur
Copy link
Member

dmitshur commented Jun 21, 2016

Thanks for the reminder.

I've updated the wiki to reflect the changes of #385. The final solution to #385 was the simplest possible that resolved my immediate need and addressed one bullet point, but it does not resolve all of issues with the file block parsing implementation.

As I mentioned in #385 (comment), resolving the rest is not easy:

I think this is the best that's possible before refactoring the entire LineFmt thing, which is extremely constraining. But refactoring LineFmt may not be easy, even lintapp depends on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants