shiny/driver/gldriver: revert "update the open gl context after making it current"

dmitshur · dmitshur · commit 1fea468a75e9 · 2019-12-24T04:42:20.000Z
This reverts CL 154461. [NSOpenGLContext update] must be called from the main thread if the context has a view. The makeCurrentContext function is not called from the main thread, so it is not thread safe to make a direct [ctx update]; call in it. Doing so causes gldriver to crash with a SIGILL signal when compiled with Xcode 11.1 or newer on macOS Catalina. Fixes golang/go#35177 Change-Id: I566c9526cddf31ed981312466f8843c2030d6692 Reviewed-on: https://go-review.googlesource.com/c/exp/+/212245 Reviewed-by: Nigel Tao <nigeltao@golang.org>
diff --git a/shiny/driver/gldriver/cocoa.m b/shiny/driver/gldriver/cocoa.m
@@ -34,7 +34,6 @@
 void makeCurrentContext(uintptr_t context) {
 	NSOpenGLContext* ctx = (NSOpenGLContext*)context;
 	[ctx makeCurrentContext];
-	[ctx update];
 }
 
 void flushContext(uintptr_t context) {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@`
`34`	`34`	`void makeCurrentContext(uintptr_t context) {`
`35`	`35`	`NSOpenGLContext* ctx = (NSOpenGLContext*)context;`
`36`	`36`	`[ctx makeCurrentContext];`
`37`		`- [ctx update];`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`void flushContext(uintptr_t context) {`