Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Commit f75bbc3

Browse files
committed
Allow invalid lock version to be added to the Q
When the version from the lock is immdiately discarded due to not matching the constraint, nothing is logged and it's not clear that the lock was broken. Allowing it be be added to the version queue, lets it be evaluated first, traced and clearly show why it wasn't used.
1 parent 5dd0593 commit f75bbc3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/gps/solver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -989,8 +989,8 @@ func (s *solver) getLockVersionIfValid(id ProjectIdentifier) (Version, error) {
989989

990990
if !found {
991991
// No match found, which means we're going to be breaking the lock
992+
// Still return the invalid version so that is included in the trace
992993
s.b.breakLock()
993-
return nil, nil
994994
}
995995
}
996996

0 commit comments

Comments
 (0)