cmd/dep: fix setting importer tests as parallel

Use the test helper so that it can check for any problems up-front.

Author: carolynvs

cmd/dep/base_importer_test.go

@@ -396,8 +396,6 @@ func TestBaseImporter_ImportProjects(t *testing.T) {
 		name := name
 		tc := tc
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			err := tc.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
 				i := newBaseImporter(logger, true, sm)
 				convertErr := i.importPackages(tc.projects, tc.defaultConstraintFromLock)
@@ -426,6 +424,7 @@ type convertTestCase struct {
 func (tc convertTestCase) Exec(t *testing.T, convert func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error)) error {
 	h := test.NewHelper(t)
 	defer h.Cleanup()
+	h.Parallel()
 
 	ctx := newTestContext(h)
 	sm, err := ctx.SourceManager()

cmd/dep/glide_importer_test.go

@@ -176,8 +176,6 @@ func TestGlideConfig_Convert(t *testing.T) {
 		name := name
 		testCase := testCase
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
 				g := newGlideImporter(logger, true, sm)
 				g.glideConfig = testCase.yaml

cmd/dep/godep_importer_test.go

@@ -80,8 +80,6 @@ func TestGodepConfig_Convert(t *testing.T) {
 		name := name
 		testCase := testCase
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
 				g := newGodepImporter(logger, true, sm)
 				g.json = testCase.json

cmd/dep/gopath_scanner_test.go

@@ -17,9 +17,10 @@ const testProject1 string = "github.com/sdboyer/deptest"
 const testProject2 string = "github.com/sdboyer/deptestdos"
 
 func TestGopathScanner_OverlayManifestConstraints(t *testing.T) {
-	t.Parallel()
-
 	h := test.NewHelper(t)
+	h.Parallel()
+	defer h.Cleanup()
+
 	ctx := newTestContext(h)
 
 	pi1 := gps.ProjectIdentifier{ProjectRoot: gps.ProjectRoot(testProject1)}
@@ -69,9 +70,10 @@ func TestGopathScanner_OverlayManifestConstraints(t *testing.T) {
 }
 
 func TestGopathScanner_OverlayLockProjects(t *testing.T) {
-	t.Parallel()
-
 	h := test.NewHelper(t)
+	h.Parallel()
+	defer h.Cleanup()
+
 	ctx := newTestContext(h)
 
 	rootM := dep.NewManifest()

cmd/dep/govend_importer_test.go

@@ -67,8 +67,6 @@ func TestGovendConfig_Convert(t *testing.T) {
 		name := name
 		testCase := testCase
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
 				g := newGovendImporter(logger, true, sm)
 				g.yaml = testCase.yaml

cmd/dep/vndr_importer_test.go

@@ -57,8 +57,6 @@ func TestVndrConfig_Convert(t *testing.T) {
 		name := name
 		testCase := testCase
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
 				g := newVndrImporter(logger, true, sm)
 				g.packages = testCase.packages