internal/fs: more nits

Signed-off-by: Ibrahim AshShohail <[email protected]>

Author: ibrasho

internal/fs/fs.go

@@ -296,8 +296,11 @@ func copySymlink(src, dst string) error {
 	}
 
 	err = os.Symlink(resolved, dst)
+	if err != nil {
+		return errors.Wrapf(err, "failed to create symlink %s to %s", src, resolved)
+	}
 
-	return errors.Wrapf(err, "failed to create symlink %s to %s", src, resolved)
+	return nil
 }
 
 // IsDir determines is the path given is a directory or not.

internal/fs/fs_test.go

@@ -820,8 +820,7 @@ func TestIsSymlink(t *testing.T) {
 		}
 
 		inaccessibleSymlink = filepath.Join(dir, "symlink")
-		err = os.Symlink(inaccessibleFile, inaccessibleSymlink)
-		return err
+		return os.Symlink(inaccessibleFile, inaccessibleSymlink)
 	})
 	defer cleanup()
 	if err != nil {