Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Commit 30ea015

Browse files
committed
misc: Clean up CHANGELOG, add TODO from #1509
1 parent 4437e02 commit 30ea015

File tree

2 files changed

+24
-23
lines changed

2 files changed

+24
-23
lines changed

CHANGELOG.md

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,34 @@
1-
# v0.3.3 (Unreleased)
1+
# v0.4.0 (Unreleased)
22

33
NEW FEATURES:
4-
* Add support for importing from [glock](https://github.com/robfig/glock) based projects (#1422).
5-
* Add support for importing from [govendor](https://github.com/kardianos/govendor)
6-
based projects (#815).
7-
* Allow override of cache directory location using environment variable
8-
`DEPCACHEDIR`. ([#1234](https://github.com/golang/dep/pull/1234))
9-
* Add support for template output in `dep status`. (#1389)
10-
* Each element in a multi-item TOML array is output on its own line. (#1461)
4+
* Add support for importing from [glock](https://github.com/robfig/glock) based projects. ([#1422](https://github.com/golang/dep/pull/1422)
5+
* Add support for importing from [govendor](https://github.com/kardianos/govendor) based projects. ([#815](https://github.com/golang/dep/pull/815)
6+
* Allow override of cache directory location using environment variable `DEPCACHEDIR`. ([#1234](https://github.com/golang/dep/pull/1234))
7+
* Add support for template output in `dep status`. ([#1389](https://github.com/golang/dep/pull/1389)
8+
* Each element in a multi-item TOML array is output on its own line. ([#1461](https://github.com/golang/dep/pull/1461)
119

1210
BUG FIXES:
1311

14-
* Releases targeting Windows now have a `.exe` suffix (#1291).
15-
* Adaptively recover from dirty and corrupted git repositories in cache (#1279).
16-
* Suppress git password prompts in more places (#1357).
17-
* Fix `-no-vendor` flag for `ensure -update` (#1361).
18-
* Validate `git ls-remote` output and ignore all malformed lines (#1379)
19-
* Support [gopkg.in version zero](http://labix.org/gopkg.in#VersionZero) (#1243).
20-
* Fix how dep status print revision constraints. (#1421)
21-
* Add optional `-v` flag to ensure sub command's syntax. (#1458)
12+
* Releases targeting Windows now have a `.exe` suffix. ([#1291](https://github.com/golang/dep/pull/1291)
13+
* Adaptively recover from dirty and corrupted git repositories in cache. ([#1279](https://github.com/golang/dep/pull/1279)
14+
* Suppress git password prompts in more places. ([#1357](https://github.com/golang/dep/pull/1357)
15+
* Fix `-no-vendor` flag for `ensure -update`. ([#1361](https://github.com/golang/dep/pull/1361)
16+
* Validate `git ls-remote` output and ignore all malformed lines. ([#1379](https://github.com/golang/dep/pull/1379)
17+
* Support [gopkg.in version zero](http://labix.org/gopkg.in#VersionZero). ([#1243](https://github.com/golang/dep/pull/1243)
18+
* Fix how dep status print revision constraints. ([#1421](https://github.com/golang/dep/pull/1421)
19+
* Add optional `-v` flag to ensure sub command's syntax. ([#1458](https://github.com/golang/dep/pull/1458)
20+
* Allow URLs containing ports in `Gopkg.toml` `source` fields. ([#1509](https://github.com/golang/dep/pull/1509)
2221

2322
IMPROVEMENTS:
2423

25-
* Log as dependencies are pre-fetched during dep init ([#1176](https://github.com/golang/dep/pull/1176)).
26-
* Make the gps package importable ([#1349](https://github.com/golang/dep/pull/1349)).
27-
* Improve file copy performance by not forcing a file sync (PR #1408).
28-
* Skip empty constraints during import ([#1414](https://github.com/golang/dep/pull/1349))
29-
* Handle errors when writing status output ([#1420](https://github.com/golang/dep/pull/1420))
30-
* Add constraint for locked projects in `status`. (#962)
24+
* Log as dependencies are pre-fetched during dep init. ([#1176](https://github.com/golang/dep/pull/1176))
25+
* Make the gps package importable. ([#1349](https://github.com/golang/dep/pull/1349))
26+
* Improve file copy performance by not forcing a file sync. ([#1408](https://github.com/golang/dep/pull/1408)
27+
* Skip empty constraints during import. ([#1414](https://github.com/golang/dep/pull/1349))
28+
* Handle errors when writing status output. ([#1420](https://github.com/golang/dep/pull/1420))
29+
* Add constraint for locked projects in `dep status`. ([#962](https://github.com/golang/dep/pull/962)
3130
* Make external config importers error tolerant. ([#1315](https://github.com/golang/dep/pull/1315))
32-
* Show LATEST and VERSION as the same type in status. (#1515)
31+
* Show LATEST and VERSION as the same type in status. ([#1515](https://github.com/golang/dep/pull/1515)
3332

3433
# v0.3.2
3534

gps/source_manager.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,8 @@ func (sm *SourceMgr) DeduceProjectRoot(ip string) (ProjectRoot, error) {
539539
return "", ErrSourceManagerIsReleased
540540
}
541541

542+
// TODO(sdboyer) refactor deduceRootPath() so that this validation can move
543+
// back down below a cache point, rather than executing on every call.
542544
if !pathvld.MatchString(ip) {
543545
return "", errors.Errorf("%q is not a valid import path", ip)
544546
}

0 commit comments

Comments
 (0)