Merge pull request #529 from ibrasho-forks/handle-init-in-GOPATH/src-issue

Show a clear error message when trying to 'dep init' in $GOPATH/src

Author: sdboyer

context.go

@@ -214,6 +214,10 @@ func (c *Ctx) resolveProjectRoot(path string) (string, error) {
 func (c *Ctx) SplitAbsoluteProjectRoot(path string) (string, error) {
 	srcprefix := filepath.Join(c.GOPATH, "src") + string(filepath.Separator)
 	if internal.HasFilepathPrefix(path, srcprefix) {
+		if len(path) <= len(srcprefix) {
+			return "", errors.New("dep does not currently support using $GOPATH/src as the project root.")
+		}
+
 		// filepath.ToSlash because we're dealing with an import path now,
 		// not an fs path
 		return filepath.ToSlash(path[len(srcprefix):]), nil

context_test.go

@@ -63,10 +63,16 @@ func TestSplitAbsoluteProjectRoot(t *testing.T) {
 		}
 	}
 
-	// test where it should return error
-	got, err := depCtx.SplitAbsoluteProjectRoot("tra/la/la/la")
+	// test where it should return an error when directly within $GOPATH/src
+	got, err := depCtx.SplitAbsoluteProjectRoot(filepath.Join(depCtx.GOPATH, "src"))
+	if err == nil || !strings.Contains(err.Error(), "$GOPATH/src") {
+		t.Fatalf("should have gotten an error for use directly in $GOPATH/src, but got %s", got)
+	}
+
+	// test where it should return an error
+	got, err = depCtx.SplitAbsoluteProjectRoot("tra/la/la/la")
 	if err == nil {
-		t.Fatalf("should have gotten error but did not for tra/la/la/la: %s", got)
+		t.Fatalf("should have gotten an error but did not for tra/la/la/la: %s", got)
 	}
 }