Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Commit 0df7f6a

Browse files
committed
Remove some old TODOs that no longer apply
1 parent 7d36525 commit 0df7f6a

File tree

4 files changed

+1
-8
lines changed

4 files changed

+1
-8
lines changed

analyzer.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ func (a Analyzer) DeriveManifestAndLock(path string, n gps.ProjectRoot) (gps.Man
4040
if err != nil {
4141
return nil, nil, err
4242
}
43-
// TODO: No need to return lock til we decide about preferred versions, see
44-
// https://github.com/sdboyer/gps/wiki/gps-for-Implementors#preferred-versions.
43+
4544
return m, nil, nil
4645
}
4746

internal/gps/bridge.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,6 @@ func (b *bridge) breakLock() {
201201

202202
for _, lp := range b.s.rd.rl.Projects() {
203203
if _, is := b.s.sel.selected(lp.pi); !is {
204-
// TODO(sdboyer) use this as an opportunity to detect
205-
// inconsistencies between upstream and the lock (e.g., moved tags)?
206204
pi, v := lp.pi, lp.Version()
207205
go func() {
208206
// Sync first

internal/gps/constraint_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,6 @@ func TestBranchConstraintOps(t *testing.T) {
9595
}
9696

9797
// Now add same rev to different branches
98-
// TODO(sdboyer) this might not actually be a good idea, when you consider the
99-
// semantics of floating versions...matching on an underlying rev might be
100-
// nice in the short term, but it's probably shit most of the time
10198
v5 := v2.Pair(Revision("snuffleupagus")).(versionPair)
10299
if !v5.Matches(v3) {
103100
t.Errorf("%s should match %s", gu(v5), gu(v3))

internal/gps/result.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ func WriteDepTree(basedir string, l Lock, sm SourceManager, sv bool) error {
7373
if sv {
7474
filepath.Walk(to, stripVendor)
7575
}
76-
// TODO(sdboyer) dump version metadata file
7776
}
7877

7978
return nil

0 commit comments

Comments
 (0)