Skip to content

Commit 8634188

Browse files
author
Bryan C. Mills
committed
acme/autocert: skip renewal tests broken on windows/arm64
For golang/go#51080 Change-Id: Icf4414ab58bdea44b793a66770b4c05f9faf5387 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385675 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Jeremy Faller <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 1e6e349 commit 8634188

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

acme/autocert/renewal_test.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"context"
99
"crypto"
1010
"crypto/ecdsa"
11+
"runtime"
1112
"testing"
1213
"time"
1314

@@ -42,6 +43,15 @@ func TestRenewalNext(t *testing.T) {
4243
}
4344

4445
func TestRenewFromCache(t *testing.T) {
46+
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
47+
// This test was observed to fail frequently in Dial with "connectex: No
48+
// connection could be made because the target machine actively refused it."
49+
//
50+
// Failures started around CL 381715, so it looks to me (bcmills) like an
51+
// undiagnosed bug in (or exposed by) acmetest.CAServer.
52+
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
53+
}
54+
4555
man := testManager(t)
4656
man.RenewBefore = 24 * time.Hour
4757

@@ -127,6 +137,15 @@ func TestRenewFromCache(t *testing.T) {
127137
}
128138

129139
func TestRenewFromCacheAlreadyRenewed(t *testing.T) {
140+
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
141+
// This test was observed to fail frequently in Dial with "connectex: No
142+
// connection could be made because the target machine actively refused it."
143+
//
144+
// Failures started around CL 381715, so it looks to me (bcmills) like an
145+
// undiagnosed bug in (or exposed by) acmetest.CAServer.
146+
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
147+
}
148+
130149
ca := acmetest.NewCAServer(t).Start()
131150
man := testManager(t)
132151
man.RenewBefore = 24 * time.Hour

0 commit comments

Comments
 (0)