Skip to content

Commit 5c72a88

Browse files
author
Bryan C. Mills
committed
sha3: remove go:nocheckptr annotation
As of Go 1.14.1, -d=checkptr no longer errors on unaligned reads of non-pointer data. This reverts the code change (but not the test) from CL 222855. Fixes golang/go#37644 Updates golang/go#37298 Change-Id: I935c773a3541ed8dca7eb005d39a082eb5f10eb8 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/249378 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]>
1 parent 123391f commit 5c72a88

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

sha3/xor_unaligned.go

-9
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,6 @@ func (b *storageBuf) asBytes() *[maxRate]byte {
1616
return (*[maxRate]byte)(unsafe.Pointer(b))
1717
}
1818

19-
//go:nocheckptr
20-
//
21-
// xorInUnaligned intentionally reads the input buffer as an unaligned slice of
22-
// integers. The language spec is not clear on whether that is allowed.
23-
// See:
24-
// https://golang.org/issue/37644
25-
// https://golang.org/issue/37298
26-
// https://golang.org/issue/35381
27-
2819
// xorInUnaligned uses unaligned reads and writes to update d.a to contain d.a
2920
// XOR buf.
3021
func xorInUnaligned(d *state, buf []byte) {

0 commit comments

Comments
 (0)