Skip to content

Commit 4570a08

Browse files
author
Bryan C. Mills
committed
internal/wycheproof: skip on builders with flaky network connections
This test downloads JSON test files from GitHub. If the network connection flakes, the test may hang indefinitely, and builders with flaky network connections might want to avoid unnecessary downloading anyway. Fixes golang/go#50076 Change-Id: I0655a34fce8a003794290c0c82ae75492eda4429 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/370659 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Katie Hockman <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 5770296 commit 4570a08

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

internal/wycheproof/wycheproof_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ func TestMain(m *testing.M) {
3333
log.Printf("skipping test because 'go' command is unavailable: %v", err)
3434
os.Exit(0)
3535
}
36+
if os.Getenv("GO_BUILDER_FLAKY_NET") != "" {
37+
log.Printf("skipping test because GO_BUILDER_FLAKY_NET is set")
38+
os.Exit(0)
39+
}
3640

3741
// Download the JSON test files from github.com/google/wycheproof
3842
// using `go mod download -json` so the cached source of the testdata

0 commit comments

Comments
 (0)