Skip to content

Commit faea4fa

Browse files
committed
dashboard: add windows-arm64 back in using azure vms
Add back windows-arm64 support, using reverse builders based on Azure VMs. At the moment only windows 11 is available. Updates golang/go#57408. Change-Id: Id93adf920226e13f74ec921e9c70765837a9cca8 Reviewed-on: https://go-review.googlesource.com/c/build/+/460837 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Than McIntosh <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
1 parent 029f06c commit faea4fa

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

dashboard/builders.go

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,7 @@ var slowBotAliases = map[string]string{
100100
"windows-386": "windows-386-2008",
101101
"windows-amd64": "windows-amd64-2016",
102102
"windows-arm": "windows-arm-zx2c4",
103-
// TODO:(golang/go#47019) - uncomment when builder returns and
104-
// update test.
105-
// "windows-arm64": "windows-arm64-11",
103+
"windows-arm64": "windows-arm64-11",
106104
}
107105

108106
// Builders are the different build configurations.
@@ -568,6 +566,12 @@ var Hosts = map[string]*HostConfig{
568566
ExpectNum: 0,
569567
Owners: []*gophers.Person{gh("zx2c4")},
570568
},
569+
"host-windows11-arm64-azure": { // host name known to cmd/buildlet/stage0, cannot change
570+
Notes: "Azure windows 11 arm64 VMs",
571+
HostArch: "windows-arm64",
572+
IsReverse: true,
573+
ExpectNum: 5,
574+
},
571575
}
572576

573577
func gh(githubUsername string) *gophers.Person {
@@ -2463,6 +2467,17 @@ func init() {
24632467
"GOARM=7",
24642468
"GO_TEST_TIMEOUT_SCALE=3"},
24652469
})
2470+
addBuilder(BuildConfig{
2471+
Name: "windows-arm64-11",
2472+
HostType: "host-windows11-arm64-azure",
2473+
numTryTestHelpers: 1,
2474+
env: []string{
2475+
"GOARCH=arm64",
2476+
// Note: GOMAXPROCS=4 workaround for go.dev/issue/51019
2477+
// tentatively removed here, since Azure VMs have 3x more
2478+
// RAM than the previous win11/arm64 machines.
2479+
},
2480+
})
24662481
addBuilder(BuildConfig{
24672482
Name: "darwin-amd64-10_14",
24682483
HostType: "host-darwin-amd64-10_14-aws",

dashboard/builders_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -729,10 +729,7 @@ func TestSlowBotAliases(t *testing.T) {
729729
}
730730
ports := strings.Fields(string(out))
731731

732-
done := map[string]bool{
733-
// TODO:(golang/go#47019) - remove when alias added
734-
"windows-arm64": true,
735-
}
732+
done := map[string]bool{}
736733

737734
var add bytes.Buffer
738735
check := func(term string, isArch bool) {

0 commit comments

Comments
 (0)