app/appengine: delete old "broke the build" code

It hasn't worked in years.

This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced.

Updates golang/go#34744
Updates golang/go#12509

Change-Id: I9f8445046961ccbe97f7b9c85c0772393bf7d547
Reviewed-on: https://go-review.googlesource.com/c/build/+/208322
Reviewed-by: Bryan C. Mills <[email protected]>
Reviewed-by: Andrew Gerrand <[email protected]>

Author: bradfitz

app/appengine/app.yaml

@@ -5,7 +5,7 @@ handlers:
   - url: /static
     static_dir: app/appengine/static
     secure: always
-  - url: /(init|buildtest|_ah/queue/go/delay)
+  - url: /(init|buildtest)
     script: auto
     login: admin
     secure: always

app/appengine/dash.go

@@ -6,7 +6,6 @@ package main
 
 import (
 	"context"
-	"encoding/gob"
 	"net/http"
 	"sort"
 	"strings"
@@ -15,8 +14,6 @@ import (
 )
 
 func main() {
-	gob.Register(&Commit{}) // needed for google.golang.org/appengine/delay
-
 	// admin handlers
 	handleFunc("/init", initHandler)
 

app/appengine/handler.go

@@ -451,10 +451,7 @@ func resultHandler(r *http.Request) (interface{}, error) {
 		if err := com.AddResult(c, res); err != nil {
 			return fmt.Errorf("AddResult: %v", err)
 		}
-		// Send build failure notifications, if necessary.
-		// Note this must run after the call AddResult, which
-		// populates the Commit's ResultData field.
-		return notifyOnFailure(c, com, res.Builder)
+		return nil
 	}
 	return nil, datastore.RunInTransaction(c, tx, nil)
 }

app/appengine/notify.go

@@ -220,6 +220,7 @@ func testHandler(w http.ResponseWriter, r *http.Request) {
 			body = new(bytes.Buffer)
 			json.NewEncoder(body).Encode(t.req)
 		}
+		const domain = "build.golang.org"
 		url := "http://" + domain + t.path
 		if t.vals != nil {
 			url += "?" + t.vals.Encode() + "&version=3"