internal/task: include date in vscode-go github release note

h9jiang · h9jiang · commit dca1b923804a · 2024-10-07T14:54:06.000Z
For golang/vscode-go#3500 Change-Id: I24844b96621d641cbb50378ea7a4adbdd38975f4 Reviewed-on: https://go-review.googlesource.com/c/build/+/617477 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/internal/task/releasevscodego.go b/internal/task/releasevscodego.go
@@ -498,6 +498,8 @@ func vsixFileName(release releaseVersion, prerelease string) string {
 // vscodeGoReleaseData holds data for the "vscode-go" extension release notes
 // template.
 type vscodeGoReleaseData struct {
+	Date string
+
 	// PreviousTag and CurrentTag are tags used to show the differences between
 	// the current release and the previous one.
 	PreviousTag string
@@ -612,6 +614,7 @@ See release https://github.com/golang/vscode-go/releases/tag/%s for details.`
 
 		nextStable := releaseVersion{Major: release.Major, Minor: release.Minor + 1, Patch: 0}.String()
 		data = vscodeGoReleaseData{
+			Date:        time.Now().Format(time.DateOnly),
 			CurrentTag:  current,
 			PreviousTag: previous,
 			// For insider version, the milestone will point to the next stable minor.
@@ -636,6 +639,7 @@ See release https://github.com/golang/vscode-go/releases/tag/%s for details.`
 		}
 
 		data = vscodeGoReleaseData{
+			Date:        time.Now().Format(time.DateOnly),
 			CurrentTag:  current,
 			PreviousTag: previous,
 			Milestone:   release.String(),
diff --git a/internal/task/releasevscodego_test.go b/internal/task/releasevscodego_test.go
@@ -688,12 +688,17 @@ CHANGE FOR v0.42.0 LINE 2
 				Gerrit: gerrit,
 			}
 
-			got, err := tasks.vscodeGoGitHubReleaseBody(ctx, tc.release, tc.prerelease)
+			gotBody, err := tasks.vscodeGoGitHubReleaseBody(ctx, tc.release, tc.prerelease)
 			if err != nil {
 				t.Fatal(err)
 			}
 
-			if diff := cmp.Diff(testdataFile(t, tc.wantContent), got); diff != "" {
+
+			re := regexp.MustCompile(`Date: (.*)\n`)
+			want := re.ReplaceAllString(testdataFile(t, tc.wantContent), "\n")
+			got := re.ReplaceAllString(string(gotBody), "\n")
+
+			if diff := cmp.Diff(want, got); diff != "" {
 				t.Errorf("body text mismatch (-want +got):\n%s", diff)
 			}
 		})
diff --git a/internal/task/template/vscode-go-release-note.md b/internal/task/template/vscode-go-release-note.md
@@ -2,6 +2,9 @@
 This is the [pre-release version](https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions) of {{ .NextStable }}.
 
 {{ end -}}
+
+Date: {{ .Date }}
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/{{.PreviousTag}}...{{.CurrentTag}}
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3A{{.Milestone}}
 {{- if .Body }}
diff --git a/internal/task/testdata/vscode-go-next-insider-minor.md b/internal/task/testdata/vscode-go-next-insider-minor.md
@@ -1,5 +1,7 @@
 This is the [pre-release version](https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions) of v0.44.0.
 
+Date: 2002-01-02
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/v0.42.0-rc.1...v0.43.0
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.44.0
 
diff --git a/internal/task/testdata/vscode-go-next-insider-patch.md b/internal/task/testdata/vscode-go-next-insider-patch.md
@@ -1,5 +1,7 @@
 This is the [pre-release version](https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions) of v0.44.0.
 
+Date: 2002-01-02
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/v0.42.0-rc.1...v0.43.4
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.44.0
 
diff --git a/internal/task/testdata/vscode-go-next-stable-minor.md b/internal/task/testdata/vscode-go-next-stable-minor.md
@@ -1,3 +1,5 @@
+Date: 2002-01-02
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/v0.42.1...v0.44.0
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.44.0
 
diff --git a/internal/task/testdata/vscode-go-next-stable-patch.md b/internal/task/testdata/vscode-go-next-stable-patch.md
@@ -1,2 +1,4 @@
+Date: 2002-01-02
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/v0.42.1...v0.42.2
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.42.2
diff --git a/internal/task/testdata/vscode-go-rc-next-stable-minor.md b/internal/task/testdata/vscode-go-rc-next-stable-minor.md
@@ -1,3 +1,5 @@
+Date: 2002-01-02
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/v0.42.1...v0.44.0-rc.4
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.44.0
 
diff --git a/internal/task/testdata/vscode-go-rc-next-stable-patch.md b/internal/task/testdata/vscode-go-rc-next-stable-patch.md
@@ -1,3 +1,5 @@
+Date: 2002-01-02
+
 **Full Changelog**: https://github.com/golang/vscode-go/compare/v0.42.1...v0.42.2-rc.3
 **Milestone**: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.42.2
 

Original file line number	Diff line number	Diff line change
`@@ -688,12 +688,17 @@ CHANGE FOR v0.42.0 LINE 2`
`688`	`688`	`Gerrit: gerrit,`
`689`	`689`	`}`
`690`	`690`
`691`		`- got, err := tasks.vscodeGoGitHubReleaseBody(ctx, tc.release, tc.prerelease)`
	`691`	`+ gotBody, err := tasks.vscodeGoGitHubReleaseBody(ctx, tc.release, tc.prerelease)`
`692`	`692`	`if err != nil {`
`693`	`693`	`t.Fatal(err)`
`694`	`694`	`}`
`695`	`695`
`696`		`- if diff := cmp.Diff(testdataFile(t, tc.wantContent), got); diff != "" {`
	`696`	`+`
	`697`	+ re := regexp.MustCompile(`Date: (.*)\n`)
	`698`	`+ want := re.ReplaceAllString(testdataFile(t, tc.wantContent), "\n")`
	`699`	`+ got := re.ReplaceAllString(string(gotBody), "\n")`
	`700`	`+`
	`701`	`+ if diff := cmp.Diff(want, got); diff != "" {`
`697`	`702`	`t.Errorf("body text mismatch (-want +got):\n%s", diff)`
`698`	`703`	`}`
`699`	`704`	`})`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+Date: 2002-01-02`
	`2`	`+`
`1`	`3`	`Full Changelog: https://github.com/golang/vscode-go/compare/v0.42.1...v0.44.0`
`2`	`4`	`Milestone: https://github.com/golang/vscode-go/issues?q=milestone%3Av0.44.0`
`3`	`5`