Skip to content

Commit dc1d16a

Browse files
0introgopherbot
authored andcommitted
internal/coordinator/remote: fix log message in legacyIncomingSSHPostAuth and IncomingSSHPostAuth
In the Plan 9 case, a log message is printed when ipErr != nil, but the wrong variable err was displayed instead of ipErr. Updates golang/go#53571 Change-Id: I4acab14f830b5cc0ae7a7863199c0b0f70af6524 Reviewed-on: https://go-review.googlesource.com/c/build/+/414595 Auto-Submit: Carlos Amedee <[email protected]> Run-TryBot: David du Colombier <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Carlos Amedee <[email protected]>
1 parent d343cdf commit dc1d16a

File tree

1 file changed

+2
-2
lines changed
  • internal/coordinator/remote

1 file changed

+2
-2
lines changed

internal/coordinator/remote/ssh.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ func (ss *SSHServer) legacyIncomingSSHPostAuth(s gssh.Session, rb *Buildlet) {
313313
case "plan9":
314314
fmt.Fprintf(s, "# Plan9 user/pass: glenda/glenda123\n")
315315
if ipErr != nil {
316-
fmt.Fprintf(s, "# Failed to get IP out of %q: %v\n", rb.Buildlet().IPPort(), err)
316+
fmt.Fprintf(s, "# Failed to get IP out of %q: %v\n", rb.Buildlet().IPPort(), ipErr)
317317
return
318318
}
319319
cmd = exec.Command("/usr/local/bin/drawterm",
@@ -457,7 +457,7 @@ func (ss *SSHServer) IncomingSSHPostAuth(s gssh.Session, rs *Session) {
457457
case "plan9":
458458
fmt.Fprintf(s, "# Plan9 user/pass: glenda/glenda123\n")
459459
if ipErr != nil {
460-
fmt.Fprintf(s, "# Failed to get IP out of %q: %v\n", bc.IPPort(), err)
460+
fmt.Fprintf(s, "# Failed to get IP out of %q: %v\n", bc.IPPort(), ipErr)
461461
return
462462
}
463463
cmd = exec.Command("/usr/local/bin/drawterm",

0 commit comments

Comments
 (0)