Skip to content

Commit da30d7a

Browse files
author
Bryan C. Mills
committed
dashboard: skip x/review on slow 32-bit builders
x/review is fairly disk-intensive (it shells out to 'git'), and also mostly for use by Go contributors (a smaller subset of Go users in general). It frequently times out on two particular 32-bit builders. I don't think we particularly need the coverage from those two builders for this repo, so rather than trying to speed up the test or tweak the scale factors, let's just skip it. Fixes golang/go#49529 Fixes golang/go#49530 Change-Id: I8da1216ebdf9287ae78d52bb03187b65eb33c9ee Reviewed-on: https://go-review.googlesource.com/c/build/+/363495 Trust: Bryan C. Mills <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent 85834a0 commit da30d7a

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

dashboard/builders.go

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1900,9 +1900,17 @@ func init() {
19001900
numTryTestHelpers: 4,
19011901
})
19021902
addBuilder(BuildConfig{
1903-
Name: "openbsd-386-68",
1904-
HostType: "host-openbsd-386-68",
1905-
tryBot: explicitTrySet("sys"),
1903+
Name: "openbsd-386-68",
1904+
HostType: "host-openbsd-386-68",
1905+
tryBot: explicitTrySet("sys"),
1906+
buildsRepo: func(repo, branch, goBranch string) bool {
1907+
if repo == "review" {
1908+
// https://golang.org/issue/49529: git seems to be too slow on this
1909+
// platform.
1910+
return false
1911+
}
1912+
return buildRepoByDefault(repo)
1913+
},
19061914
distTestAdjust: noTestDirAndNoReboot,
19071915
numTryTestHelpers: 4,
19081916
})
@@ -1975,8 +1983,16 @@ func init() {
19751983
distTestAdjust: noTestDirAndNoReboot,
19761984
})
19771985
addBuilder(BuildConfig{
1978-
Name: "netbsd-arm-bsiegert",
1979-
HostType: "host-netbsd-arm-bsiegert",
1986+
Name: "netbsd-arm-bsiegert",
1987+
HostType: "host-netbsd-arm-bsiegert",
1988+
buildsRepo: func(repo, branch, goBranch string) bool {
1989+
if repo == "review" {
1990+
// https://golang.org/issue/49530: This test seems to be too slow even
1991+
// with a long scale factor.
1992+
return false
1993+
}
1994+
return buildRepoByDefault(repo)
1995+
},
19801996
distTestAdjust: noTestDirAndNoReboot,
19811997
tryBot: nil,
19821998
env: []string{

0 commit comments

Comments
 (0)