cmd/relui,internal/relui: create and run workflows

Create and run workflows, storing state in a postgres database. Generate
database queries using sqlc, which allows the author to have complete
control over the query structure.

The basic structure of creating and running a workflow works, but
there is still much work to do in terms of selecting which workflow to
create, recording logs, maintaining a list of currently running
workflows, and recording workflow-level results.

Task persistence needs to be updated, as the current implementation
cannot be resumed due to losing the type during marshalling.

For golang/go#47401

Change-Id: I9ccddf117d023f70568de655c482820a1152d9cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/350449
Trust: Alexander Rakoczy <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>

Author: toothrot

cmd/relui/Makefile

@@ -18,7 +18,7 @@ DEV_CFG := ${HOME}/.local/share/relui
 
 .PHONY: dev
 dev: postgres-dev docker
-	docker run --rm --name=relui-dev -v $(POSTGRES_RUN_DEV) -p 8080:8080 $(DOCKER_TAG)
+	docker run --rm --name=relui-dev -v $(POSTGRES_RUN_DEV) -e PGUSER=$(POSTGRES_USER) -e PGDATABASE=relui-dev -p 8080:8080 $(DOCKER_TAG)
 
 .PHONY: postgres-dev
 postgres-dev: $(DEV_CFG)/pgpass
@@ -38,7 +38,7 @@ schema.sql: $(MIGRATION_FILES) $(GO_FILES)
 
 .PHONY: test
 test: postgres-dev docker-test
-	docker run --rm --name=relui-test -v $(POSTGRES_RUN_DEV) -e RELUI_TEST_DATABASE="host=/var/run/postgresql user=postgres database=relui-test" golang/relui-test:$(VERSION)
+	docker run --rm --name=relui-test -v $(POSTGRES_RUN_DEV) -e PGUSER=$(POSTGRES_USER) -e PGDATABASE=relui-test golang/relui-test:$(VERSION)
 
 .PHONY: docker
 docker:

cmd/relui/README.md

@@ -9,3 +9,44 @@
 ```
 
 relui is a web interface for managing the release process of Go.
+
+## Development
+
+Run the command with the appropriate
+[libpq-style environment variables](https://www.postgresql.org/docs/current/libpq-envars.html)
+set.
+
+```bash
+PGHOST=localhost PGDATABASE=relui-dev PGUSER=postgres go run ./
+```
+
+Alternatively, using docker:
+
+```bash
+make dev
+```
+
+### Updating Queries
+
+Create or edit SQL files in `internal/relui/queries`.
+After editing the query, run `sqlc generate` in this directory. The
+`internal/relui/db` package contains the generated code.
+
+See [sqlc documentation](https://docs.sqlc.dev/en/stable/) for further
+details.
+
+## Testing
+
+Run go test with the appropriate
+[libpq-style environment variables](https://www.postgresql.org/docs/current/libpq-envars.html)
+set. If the database connection fails, database integration tests will
+be skipped. If PGDATABSE is unset, relui-test is used by default.
+
+```bash
+PGHOST=localhost PGUSER=postgres go test -v ./... ../../internal/relui/...
+```
+
+Alternatively, using docker:
+```bash
+make test
+```

cmd/relui/main.go

@@ -14,11 +14,12 @@ import (
 	"log"
 	"os"
 
+	"github.com/jackc/pgx/v4/pgxpool"
 	"golang.org/x/build/internal/relui"
 )
 
 var (
-	pgConnect   = flag.String("pg-connect", "host=/var/run/postgresql user=postgres database=relui-dev", "Postgres connection string or URI")
+	pgConnect   = flag.String("pg-connect", "", "Postgres connection string or URI. If empty, libpq connection defaults are used.")
 	onlyMigrate = flag.Bool("only-migrate", false, "Exit after running migrations. Migrations are run by default.")
 )
 
@@ -31,12 +32,12 @@ func main() {
 	if *onlyMigrate {
 		return
 	}
-	d := new(relui.PgStore)
-	if err := d.Connect(ctx, *pgConnect); err != nil {
+	db, err := pgxpool.Connect(ctx, *pgConnect)
+	if err != nil {
 		log.Fatal(err)
 	}
-	defer d.Close()
-	s, err := relui.NewServer(ctx, d)
+	defer db.Close()
+	s := relui.NewServer(db)
 	if err != nil {
 		log.Fatalf("relui.NewServer() = %v", err)
 	}

cmd/relui/sqlc.yaml

@@ -0,0 +1,12 @@
+version: "1"
+packages:
+  - name: "db"
+    path: "../../internal/relui/db"
+    queries: "../../internal/relui/queries"
+    schema: "schema.sql"
+    engine: "postgresql"
+    sql_package: "pgx/v4"
+overrides:
+  - go_type: "database/sql.NullString"
+    db_type: "jsonb"
+    nullable: true

go.mod

@@ -24,6 +24,7 @@ require (
 	github.com/googleapis/gax-go/v2 v2.0.5
 	github.com/googleapis/google-cloud-go-testing v0.0.0-20200911160855-bcd43fbb19e8
 	github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7
+	github.com/jackc/pgconn v1.10.0
 	github.com/jackc/pgx/v4 v4.13.0
 	github.com/jellevandenhooff/dkim v0.0.0-20150330215556-f50fe3d243e1
 	github.com/tarm/serial v0.0.0-20180830185346-98f6abe2eb07