Skip to content

Commit c61dc90

Browse files
committed
cmd/buildlet: ignore symlinks for now
As part of getting the x/build tests passing (trybots + post-submit), ignore the symlinks that are in the x/build repo for now. We can add support when we actually need them for something. But I imagine any test that needs them can & does just create them as needed. Updates golang/go#14594 Change-Id: I6a0584d35c8d0fc91b3cdc8114b473df7f0268c3 Reviewed-on: https://go-review.googlesource.com/c/157439 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 187891a commit c61dc90

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

cmd/buildlet/buildlet.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -810,6 +810,11 @@ func untar(r io.Reader, dir string) (err error) {
810810
return err
811811
}
812812
madeDir[abs] = true
813+
case mode&os.ModeSymlink != 0:
814+
// TODO: ignore these for now. They were breaking x/build tests.
815+
// Implement these if/when we ever have a test that needs them.
816+
// But maybe we'd have to skip creating them on Windows for some builders
817+
// without permissions.
813818
default:
814819
return badRequest(fmt.Sprintf("tar file entry %s contained unsupported file type %v", f.Name, mode))
815820
}

0 commit comments

Comments
 (0)