Skip to content

Commit c5a08f8

Browse files
committed
main.star: run longetst builders in presubmit if cmd/go is modified
This CL will cause longetst builders to be run if code in src/cmd/go is modified. There are many cmd/go tests that are skipped in short mode so only running the short tests by default leaves out a lot of coverage. Fixes golang/go#42661 Change-Id: Idd0b86220cf53560eb2ad6b6877b9431731377b9 Reviewed-on: https://go-review.googlesource.com/c/build/+/648275 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent c0d7a64 commit c5a08f8

File tree

2 files changed

+39
-0
lines changed

2 files changed

+39
-0
lines changed

generated/commit-queue.cfg

+36
Original file line numberDiff line numberDiff line change
@@ -13741,6 +13741,12 @@ config_groups {
1374113741
gerrit_ref_regexp: ".*"
1374213742
path_regexp: "src/crypto/tls/.+"
1374313743
}
13744+
location_filters {
13745+
gerrit_host_regexp: "go-review.googlesource.com"
13746+
gerrit_project_regexp: "^go$"
13747+
gerrit_ref_regexp: ".*"
13748+
path_regexp: "src/cmd/go/.+"
13749+
}
1374413750
}
1374513751
builders {
1374613752
name: "golang/try/gotip-linux-386-softfloat"
@@ -13801,6 +13807,12 @@ config_groups {
1380113807
gerrit_ref_regexp: ".*"
1380213808
path_regexp: "src/crypto/tls/.+"
1380313809
}
13810+
location_filters {
13811+
gerrit_host_regexp: "go-review.googlesource.com"
13812+
gerrit_project_regexp: "^go$"
13813+
gerrit_ref_regexp: ".*"
13814+
path_regexp: "src/cmd/go/.+"
13815+
}
1380413816
}
1380513817
builders {
1380613818
name: "golang/try/gotip-linux-amd64-longtest-aliastypeparams"
@@ -13829,6 +13841,12 @@ config_groups {
1382913841
gerrit_ref_regexp: ".*"
1383013842
path_regexp: "src/crypto/tls/.+"
1383113843
}
13844+
location_filters {
13845+
gerrit_host_regexp: "go-review.googlesource.com"
13846+
gerrit_project_regexp: "^go$"
13847+
gerrit_ref_regexp: ".*"
13848+
path_regexp: "src/cmd/go/.+"
13849+
}
1383213850
}
1383313851
builders {
1383413852
name: "golang/try/gotip-linux-amd64-longtest-noswissmap"
@@ -13862,6 +13880,12 @@ config_groups {
1386213880
gerrit_ref_regexp: ".*"
1386313881
path_regexp: "src/crypto/tls/.+"
1386413882
}
13883+
location_filters {
13884+
gerrit_host_regexp: "go-review.googlesource.com"
13885+
gerrit_project_regexp: "^go$"
13886+
gerrit_ref_regexp: ".*"
13887+
path_regexp: "src/cmd/go/.+"
13888+
}
1386513889
}
1386613890
builders {
1386713891
name: "golang/try/gotip-linux-amd64-misccompile"
@@ -14019,6 +14043,12 @@ config_groups {
1401914043
gerrit_ref_regexp: ".*"
1402014044
path_regexp: "src/crypto/tls/.+"
1402114045
}
14046+
location_filters {
14047+
gerrit_host_regexp: "go-review.googlesource.com"
14048+
gerrit_project_regexp: "^go$"
14049+
gerrit_ref_regexp: ".*"
14050+
path_regexp: "src/cmd/go/.+"
14051+
}
1402214052
}
1402314053
builders {
1402414054
name: "golang/try/gotip-linux-arm64-race"
@@ -14188,6 +14218,12 @@ config_groups {
1418814218
gerrit_ref_regexp: ".*"
1418914219
path_regexp: "src/crypto/tls/.+"
1419014220
}
14221+
location_filters {
14222+
gerrit_host_regexp: "go-review.googlesource.com"
14223+
gerrit_project_regexp: "^go$"
14224+
gerrit_ref_regexp: ".*"
14225+
path_regexp: "src/cmd/go/.+"
14226+
}
1419114227
}
1419214228
builders {
1419314229
name: "golang/try/gotip-windows-amd64-race"

main.star

+3
Original file line numberDiff line numberDiff line change
@@ -1011,6 +1011,9 @@ RUN_MODS = dict(
10111011
# Enable longtest builders on go against tip if files in the crypto/tls tree are modified,
10121012
# so that the BoGo test suite is run.
10131013
"src/crypto/tls/.+",
1014+
# Enable longtest builders on go against tip if files in the cmd/go tree are modified,
1015+
# so the many cmd/go script tests that are skipped on short are run.
1016+
"src/cmd/go/.+",
10141017
],
10151018
"protobuf": [],
10161019
}),

0 commit comments

Comments
 (0)