Skip to content

Commit c1bc870

Browse files
prattmicgopherbot
authored andcommitted
Revert "env/darwin/aws: reduce guest CPU count to 4"
This reverts CL 461775. That CL failed to update cmd/runqemubuildlet, which is used for production VM execution. Thus it had no impact. The next CL will change memory, so just revert this for now rather than fixing to avoid changing two things at once. For golang/go#48945. For golang/go#59634. Change-Id: I9f1e26f2b3ffd6caca9683242a44597b7f1d8d58 Reviewed-on: https://go-review.googlesource.com/c/build/+/484746 Run-TryBot: Michael Pratt <[email protected]> Auto-Submit: Michael Pratt <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Commit-Queue: Michael Pratt <[email protected]>
1 parent ec56ce8 commit c1bc870

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

env/darwin/aws/qemu.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ args=(
2323
-cpu host
2424
-machine q35
2525
-usb -device usb-kbd -device usb-tablet
26-
# QEMU scales poorly with CPU count on macOS (see
27-
# https://go.dev/issue/48945#issuecomment-1378850381). Increasing CPU count
28-
# also increases boot time.
29-
-smp cpus=4
26+
# macOS only likes a power-of-two number of cores, but odd socket count is
27+
# fine.
28+
-smp cpus=6,sockets=3,cores=2,threads=1
3029
-device usb-ehci,id=ehci
3130
-device nec-usb-xhci,id=xhci
3231
-global nec-usb-xhci.msi=off

0 commit comments

Comments
 (0)