Skip to content

Commit baa973b

Browse files
dmitshurgopherbot
authored andcommitted
dashboard: enable linux/loong64 builder on 1.19 release branches
It made sense for the linux/loong64 builder to only test the main branch during the port's development. Now that it's complete, update the policy to test all supported Go versions (starting with Go 1.19, when the port was added) instead of just tip. This will increase the volume of work for the builder by some amount, hopefully that's fine, it seems to have enough resources to handle it. Updates golang/go#54222. Change-Id: Ic774b9890fc4826e56613f360d6edd03f50e3deb Reviewed-on: https://go-review.googlesource.com/c/build/+/459876 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: abner chenc <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: David Chase <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
1 parent 59e4df6 commit baa973b

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

dashboard/builders.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2833,8 +2833,10 @@ func init() {
28332833
},
28342834
buildsRepo: func(repo, branch, goBranch string) bool {
28352835
switch repo {
2836-
case "go", "net", "sys":
2837-
return branch == "master" && goBranch == "master"
2836+
case "go":
2837+
return atLeastGo1(goBranch, 19)
2838+
case "net", "sys":
2839+
return branch == "master" && atLeastGo1(goBranch, 19)
28382840
default:
28392841
return false
28402842
}

dashboard/builders_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,11 @@ func TestBuilderConfig(t *testing.T) {
406406
{b("linux-amd64", "net"), both},
407407

408408
{b("linux-loong64-3a5000", "go"), onlyPost},
409+
{b("[email protected]", "go"), onlyPost},
410+
{b("[email protected]", "go"), none}, // Go 1.18 doesn't support this port.
409411
{b("linux-loong64-3a5000", "sys"), onlyPost},
412+
{b("[email protected]", "sys"), onlyPost},
413+
{b("[email protected]", "sys"), none},
410414
{b("linux-loong64-3a5000", "net"), onlyPost},
411415

412416
// OpenBSD 6.8.

0 commit comments

Comments
 (0)