internal/task: simplify test case inputs in TestTweetRelease

tweetImage was simplified to not use the go.dev/dl/?mode=json API
without breaking tests. This change simplifies the test cases to
have minimal local inputs without needing to use the internet.

Fixes golang/go#57062.

Change-Id: I09098413824f2338eccfac69c208c170fa125a77
Reviewed-on: https://go-review.googlesource.com/c/build/+/504520
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>

Author: dmitshur

internal/task/tweet_test.go

@@ -7,7 +7,6 @@ package task
 import (
 	"bytes"
 	"context"
-	"encoding/json"
 	"flag"
 	"fmt"
 	"image"
@@ -23,34 +22,6 @@ import (
 )
 
 func TestTweetRelease(t *testing.T) {
-	if testing.Short() {
-		// This test is useful when modifying the tweet text and image templates,
-		// but don't run it in -short mode since—for a New York minute only—this
-		// test involves making some HTTP GET requests to the internet.
-		t.Skip("skipping test that hits go.dev/dl/?mode=json read-only API in -short mode")
-	}
-
-	// Fetch real Go release file metadata for use in test cases below.
-	resp, err := http.Get("https://go.dev/dl/?mode=json&include=all")
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer resp.Body.Close()
-	if resp.StatusCode != http.StatusOK {
-		t.Fatalf("non-200 OK status code: %v", resp.Status)
-	} else if ct := resp.Header.Get("Content-Type"); ct != "application/json" {
-		t.Fatalf("got Content-Type %q, want %q", ct, "application/json")
-	}
-	var releases []WebsiteRelease
-	err = json.NewDecoder(resp.Body).Decode(&releases)
-	if err != nil {
-		t.Fatal(err)
-	}
-	var filesByVersion = make(map[string][]WebsiteFile)
-	for _, r := range releases {
-		filesByVersion[r.Version] = r.Files
-	}
-
 	tests := [...]struct {
 		name         string
 		published    []Published
@@ -62,8 +33,11 @@ func TestTweetRelease(t *testing.T) {
 		{
 			name: "minor",
 			published: []Published{
-				{Version: "go1.17.1", Files: filesByVersion["go1.17.1"]},
-				{Version: "go1.16.8", Files: filesByVersion["go1.16.8"]},
+				{Version: "go1.17.1", Files: []WebsiteFile{{
+					OS: "linux", Arch: "arm64",
+					Filename: "go1.17.1.linux-arm64.tar.gz", Size: 102606384, Kind: "archive"}},
+				},
+				{Version: "go1.16.8"},
 			},
 			security:     "Includes security fixes for A and B.",
 			announcement: "https://groups.google.com/g/golang-announce/c/dx9d7IOseHw/m/KNH37k37AAAJ",
@@ -90,8 +64,11 @@ $ go1.17.1 version
 go version go1.17.1 linux/arm64` + "\n",
 		},
 		{
-			name:         "minor-solo",
-			published:    []Published{{Version: "go1.11.1", Files: filesByVersion["go1.11.1"]}},
+			name: "minor-solo",
+			published: []Published{{Version: "go1.11.1", Files: []WebsiteFile{{
+				OS: "darwin", Arch: "amd64",
+				Filename: "go1.11.1.darwin-amd64.tar.gz", Size: 124181190, Kind: "archive"}},
+			}},
 			announcement: "https://groups.google.com/g/golang-announce/c/pFXKAfoVJqw",
 			randomSeed:   23,
 			wantLog: `tweet text:
@@ -114,8 +91,11 @@ $ go1.11.1 version
 go version go1.11.1 darwin/amd64` + "\n",
 		},
 		{
-			name:         "beta",
-			published:    []Published{{Version: "go1.17beta1", Files: filesByVersion["go1.17beta1"]}},
+			name: "beta",
+			published: []Published{{Version: "go1.17beta1", Files: []WebsiteFile{{
+				OS: "darwin", Arch: "amd64",
+				Filename: "go1.17beta1.darwin-amd64.tar.gz", Size: 135610703, Kind: "archive"}},
+			}},
 			announcement: "https://groups.google.com/g/golang-announce/c/i4EliPDV9Ok/m/MxA-nj53AAAJ",
 			randomSeed:   678,
 			wantLog: `tweet text:
@@ -140,8 +120,11 @@ $ go1.17beta1 version
 go version go1.17beta1 darwin/amd64` + "\n",
 		},
 		{
-			name:         "rc",
-			published:    []Published{{Version: "go1.17rc2", Files: filesByVersion["go1.17rc2"]}},
+			name: "rc",
+			published: []Published{{Version: "go1.17rc2", Files: []WebsiteFile{{
+				OS: "windows", Arch: "arm64",
+				Filename: "go1.17rc2.windows-arm64.zip", Size: 116660997, Kind: "archive"}},
+			}},
 			announcement: "https://groups.google.com/g/golang-announce/c/yk30ovJGXWY/m/p9uUnKbbBQAJ",
 			randomSeed:   456,
 			wantLog: `tweet text:
@@ -166,8 +149,11 @@ $ go1.17rc2 version
 go version go1.17rc2 windows/arm64` + "\n",
 		},
 		{
-			name:       "major",
-			published:  []Published{{Version: "go1.17", Files: filesByVersion["go1.17"]}},
+			name: "major",
+			published: []Published{{Version: "go1.17", Files: []WebsiteFile{{
+				OS: "freebsd", Arch: "amd64",
+				Filename: "go1.17.freebsd-amd64.tar.gz", Size: 133579378, Kind: "archive"}},
+			}},
 			security:   "Includes a super duper security fix (CVE-123).",
 			randomSeed: 123,
 			wantLog: `tweet text: