Skip to content

Commit 950e098

Browse files
dmitshurgopherbot
authored andcommitted
cmd/relui: join communication tasks in main release workflows
The next step after joining the announcement mail and tweet tasks is to append them to the end of the main existing release workflows. This removes the need for the human release coordinator to manually enter the Version (and, for minor releases, Secondary Version) parameters, since that information is already automatically computed as part of those workflows, and can be passed along. Since the website update is not yet integrated into the release flow, and as an initial safety check, add another "Wait to Announce" step that must be approved by the release coordinator, before relui proceeds to announce a recently published Go release. This change adds, but doesn't yet enable, this functionality; it's currently gated on the mergeCommTasksIntoReleaseWorkflows constant. For golang/go#53537. Change-Id: Id9046ae3de52da5ba49e4bcecda2ca427fd0e51c Reviewed-on: https://go-review.googlesource.com/c/build/+/414035 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent 9267226 commit 950e098

File tree

3 files changed

+182
-82
lines changed

3 files changed

+182
-82
lines changed

cmd/relui/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func main() {
153153
RepoOwner: "golang",
154154
RepoName: "go",
155155
}
156-
relui.RegisterReleaseWorkflows(dh, buildTasks, milestoneTasks, versionTasks)
156+
relui.RegisterReleaseWorkflows(dh, buildTasks, milestoneTasks, versionTasks, annMail, extCfg)
157157

158158
w := relui.NewWorker(dh, db, relui.NewPGListener(db))
159159
go w.Run(ctx)

internal/relui/buildrelease_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,11 @@ func testRelease(t *testing.T, wantVersion string, kind task.ReleaseKind) {
127127
},
128128
}
129129
wd := workflow.New()
130-
if err := addSingleReleaseWorkflow(buildTasks, milestoneTasks, versionTasks, wd, "go1.18", kind); err != nil {
130+
v, err := addSingleReleaseWorkflow(buildTasks, milestoneTasks, versionTasks, wd, "go1.18", kind)
131+
if err != nil {
131132
t.Fatal(err)
132133
}
134+
wd.Output("Published Go version", v)
133135
w, err := workflow.Start(wd, map[string]interface{}{
134136
"Targets to skip testing (or 'all') (optional)": []string(nil),
135137
})

0 commit comments

Comments
 (0)