Skip to content

Commit 8cb2bf7

Browse files
dmitshurgopherbot
authored andcommitted
main.star: enable linux-amd64-typesalias presubmit for Go 1.23 and tip
This is separated out in a separate CL for a more gradual rollout. Fixes golang/go#68798. Change-Id: I6a4c2f1e89ab7c6426a9b5d19e429b68ca61bee4 Reviewed-on: https://go-review.googlesource.com/c/build/+/604336 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Tim King <[email protected]> Reviewed-by: David Chase <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 9e8a03b commit 8cb2bf7

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

generated/commit-queue.cfg

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29131,7 +29131,6 @@ config_groups {
2913129131
}
2913229132
builders {
2913329133
name: "golang/try/go1.23-linux-amd64-typesalias"
29134-
includable_only: true
2913529134
disable_reuse: true
2913629135
}
2913729136
builders {
@@ -29993,7 +29992,6 @@ config_groups {
2999329992
}
2999429993
builders {
2999529994
name: "golang/try/gotip-linux-amd64-typesalias"
29996-
includable_only: true
2999729995
disable_reuse: true
2999829996
}
2999929997
builders {
@@ -86645,7 +86643,6 @@ config_groups {
8664586643
}
8664686644
builders {
8664786645
name: "golang/try/x_tools-go1.23-linux-amd64-typesalias"
86648-
includable_only: true
8664986646
disable_reuse: true
8665086647
}
8665186648
builders {
@@ -88087,7 +88084,6 @@ config_groups {
8808788084
}
8808888085
builders {
8808988086
name: "golang/try/x_tools-gotip-linux-amd64-typesalias"
88090-
includable_only: true
8809188087
disable_reuse: true
8809288088
}
8809388089
builders {

main.star

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ def define_for_issue68798():
810810
# Starting with Go 1.23, gotypesalias=1 is the default, so
811811
# a builder that sets it explicitly in the environment is expected to be a no-op.
812812
# Run it anyway to confirm that's the case for reasons motivated in go.dev/issue/68798.
813-
presubmit, postsubmit = False, True
813+
presubmit, postsubmit = True, True
814814
return (exists, presubmit, postsubmit, [])
815815

816816
return f

0 commit comments

Comments
 (0)