cmd/tip: use proxy.golang.org when building x/website

The new x/website is built in module mode. Now that proxy.golang.org
is available publicly, cmd/tip can start using it for fetching modules
when building x/website.

Also make a change to newServeMux so that httpsOnlyHandler is only used
when HTTPS is turned on. That stops redirecting to HTTPS when HTTPS is
not being served, thereby fixing HTTP-only local development mode.

Updates golang/go#26872
Updates golang/go#30232
Updates golang/go#29206

Change-Id: If0382c45b9c99540adce3a894054730f5a7a9fdb
Reviewed-on: https://go-review.googlesource.com/c/build/+/177217
Reviewed-by: Brad Fitzpatrick <[email protected]>

Author: dmitshur

cmd/tip/golangorg.go

@@ -60,6 +60,7 @@ func (b golangorgBuilder) Init(logger *log.Logger, dir, hostport string, heads m
 	install.Env = append(os.Environ(),
 		"GOROOT="+goDir,
 		"GO111MODULE=on",
+		"GOPROXY=https://proxy.golang.org",
 		"GOBIN="+binDir,
 	)
 	if err := install.Run(); err != nil {

cmd/tip/tip.go

@@ -56,7 +56,10 @@ func main() {
 
 	p := &Proxy{builder: b}
 	go p.run()
-	mux := newServeMux(p)
+	mux := newServeMux(p, serveOptions{
+		// Redirect to HTTPS only if we're actually serving HTTPS.
+		RedirectToHTTPS: *autoCertDomain != "",
+	})
 
 	log.Printf("Starting up tip server for builder %q", os.Getenv(k))
 
@@ -253,9 +256,19 @@ func (p *Proxy) poll() {
 	p.cmd = cmd
 }
 
-func newServeMux(p *Proxy) http.Handler {
+type serveOptions struct {
+	// RedirectToHTTPS controls whether requests served
+	// over HTTP should be redirected to HTTPS.
+	RedirectToHTTPS bool
+}
+
+func newServeMux(p *Proxy, opt serveOptions) http.Handler {
 	mux := http.NewServeMux()
-	mux.Handle("/", httpsOnlyHandler{p})
+	if opt.RedirectToHTTPS {
+		mux.Handle("/", httpsOnlyHandler{p})
+	} else {
+		mux.Handle("/", p)
+	}
 	mux.HandleFunc("/_ah/health", p.serveHealthCheck)
 	return mux
 }

cmd/tip/tip_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 func TestTipRedirects(t *testing.T) {
-	mux := newServeMux(&Proxy{builder: &golangorgBuilder{}})
+	mux := newServeMux(&Proxy{builder: &golangorgBuilder{}}, serveOptions{RedirectToHTTPS: true})
 	req := httptest.NewRequest("GET", "http://example.com/foo?bar=baz", nil)
 	req.Header.Set("X-Forwarded-Proto", "http")
 	w := httptest.NewRecorder()