Skip to content

Commit 8c4a1e1

Browse files
heschigopherbot
authored andcommitted
internal/relui: use workflow output with communications not merged
The workflow package requires all tasks to be referenced somehow, and they weren't if the comms tasks were disabled. For golang/go#53537. Change-Id: Iafb60cb9a73d8e1583456cee3e9667150259338e Reviewed-on: https://go-review.googlesource.com/c/build/+/416218 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Heschi Kreinick <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Heschi Kreinick <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 8b8ae5f commit 8c4a1e1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

internal/relui/workflows.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,7 @@ func addSingleReleaseWorkflow(
708708

709709
pushed := wd.Action("Push issues", milestone.PushIssues, milestones, nextVersion, kindVal, tagged)
710710
versionPublished = wd.Task("Publish to website", build.publishArtifacts, nextVersion, signedAndTestedArtifacts, pushed)
711-
711+
wd.Output("Released version", versionPublished)
712712
return versionPublished, nil
713713
}
714714

internal/workflow/workflow.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
// a value of any type and an error. The TaskContext can be used as a normal
2424
// Context, and also supports workflow features like unstructured logging.
2525
// A task only runs once all of its input Values and Dependencies are ready.
26+
// All task outputs must be used either as inputs to another task or as a
27+
// workflow Output.
2628
//
2729
// In addition to Tasks, a workflow can have Actions, which represent functions
2830
// that don't produce an output. Their Go function must only return an error,

0 commit comments

Comments
 (0)